Skip to content

Expose authdataresult.credential.secret in public header. #3089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2019
Merged

Expose authdataresult.credential.secret in public header. #3089

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69fca2f
Expose authdataresult.credential.secret in public header.
Yue-Wang-Google May 27, 2019
39aac32
fix pr issue
Yue-Wang-Google May 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions Firebase/Auth/Source/Auth/FIRAuthDataResult_Internal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,6 @@ NS_ASSUME_NONNULL_BEGIN

@interface FIRAuthDataResult () <NSSecureCoding>

/** @property credential
@brief The updated OAuth credential after the sign-in, link and reauthenticate action.
@detail This property is for OAuth sign in only.
*/
@property(nonatomic, readonly, nullable) FIROAuthCredential *credential;

/** @fn initWithUser:additionalUserInfo:
@brief Designated initializer.
@param user The signed in user reference.
Expand Down
7 changes: 0 additions & 7 deletions Firebase/Auth/Source/AuthProvider/OAuth/FIROAuthCredential_Internal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,13 +42,6 @@ NS_ASSUME_NONNULL_BEGIN
*/
@property(nonatomic, readonly, nullable) NSString *pendingToken;

/** @property secret
@brief The secret associated with this credential. This will be nil for OAuth 2.0 providers.
@detail OAuthCredential already exposes a providerId getter. This will help the developer
determine whether an access token/secret pair is needed.
*/
@property(nonatomic, readonly, nullable) NSString *secret;

/** @fn initWithProviderId:IDToken:accessToken:secret:pendingToken
@brief Designated initializer.
@param providerID The provider ID associated with the credential being created.
Expand Down
8 changes: 8 additions & 0 deletions Firebase/Auth/Source/Public/FIRAuthDataResult.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
#import <Foundation/Foundation.h>

@class FIRAdditionalUserInfo;
@class FIRAuthCredential;
@class FIRUser;

NS_ASSUME_NONNULL_BEGIN
Expand Down Expand Up @@ -44,6 +45,13 @@ NS_SWIFT_NAME(AuthDataResult)
*/
@property(nonatomic, readonly, nullable) FIRAdditionalUserInfo *additionalUserInfo;

/** @property credential
@brief This property will be non-nil after a successful headful-lite sign-in via
signInWithProvider:UIDelegate:. May be used to obtain the accessToken and/or IDToken
pertaining to a recently signed-in user.
*/
@property(nonatomic, readonly, nullable) FIRAuthCredential *credential;

@end

NS_ASSUME_NONNULL_END
7 changes: 7 additions & 0 deletions Firebase/Auth/Source/Public/FIROAuthCredential.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,13 @@ NS_SWIFT_NAME(OAuthCredential)
*/
@property(nonatomic, readonly, nullable) NSString *accessToken;

/** @property secret
@brief The secret associated with this credential. This will be nil for OAuth 2.0 providers.
@detail OAuthCredential already exposes a providerId getter. This will help the developer
determine whether an access token/secret pair is needed.
*/
@property(nonatomic, readonly, nullable) NSString *secret;

/** @fn init
@brief This class is not supposed to be instantiated directly.
*/
Expand Down