-
Notifications
You must be signed in to change notification settings - Fork 1.7k
FIAM Programmatic triggers #3081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
79 commits
Select commit
Hold shift + click to select a range
d4ba006
Add card scene to storyboard, use IBDesignable rounded corners view
christibbs 8ba72d8
Use IBdesignable rounded corners view for modal message
christibbs ed6db2d
Add card message type
christibbs cdacb13
Parse card message type, add new fields for secondary actions and lan…
christibbs ce90659
Display a really basic card message
christibbs f0d3149
Naive landscape image loading (needs error handling)
christibbs 16c8ce8
Quick bug fix
christibbs 866abe8
Wire up Display to show cards
christibbs 49d2b21
Wire up Display to show cards
christibbs 73189cf
Fix tablet width
christibbs 7f68cf6
Pick right image for orientation
christibbs 5cf57ba
Remove placeholder image sizing constraints at build time
christibbs 6d5de7e
Add more test functionality
christibbs 413189f
Better image sizes
christibbs 306898e
Size message image out
christibbs 18e31d2
Switch to body text view rather than body label
christibbs 4d25033
Merge in master
christibbs 6ca1a68
Make the body text view scrollable. Set correct text color on button.
christibbs d434545
Hook up buttons and text color
christibbs b87c0e5
Include action URL in messageClicked callback
christibbs d39b560
Fix action URL
christibbs 4ffc0bd
Update pod specs
christibbs 5f313f5
Update message clicked delegate to pass an action object, not just th…
christibbs 3a408f1
Merge branch 'master' into fiam-card-display
christibbs 6b19a1e
Change podspec versions back, hook up background color
christibbs a8df5be
Merge in master
christibbs 04c8ad1
Don't animate scroll to top on scroll view
christibbs 81584b3
Fix text scrolling bug
christibbs f4723cd
Fix portrait and landscape fetching code. Fix background color bug
christibbs 95ae8be
Merge branch 'master' into fiam-card-display
christibbs 4db3a3d
Flesh out FIRIAMMessageContentDataWithImageURLTests
christibbs d274e21
Fix up FIRIAMFetchFlowTests
christibbs 3c8f8b3
Fix up FIRIAMMessageClientCacheTests
christibbs ad34c58
Fix up FIRIAMMessageDisplayForTesting
christibbs fac48d1
Fix fetching in FIRIAMMessageContentDataWithImageURL
christibbs 121d595
Tests for message parsing
christibbs 0decd64
Merge branch 'master' into fiam-card-display
christibbs dde5f48
Fix up view controllers for banner, modal, image only. Add a view con…
christibbs 43ca3b2
Add required vertical compression resistance for primary and secondar…
christibbs 6d8ee20
Add UI tests for card view controller
christibbs 669245b
Add back deprecated messageClicked: method, call it if the newer meth…
christibbs 7224d2e
Run scripts/styles.sh
christibbs feed33d
Merge branch 'master' into fiam-programmatic-triggers
christibbs bfd3d52
Add FIRIAMDisplayExecutor logic to display an in-app message programm…
christibbs 5583219
Add a public method on FIRInAppMessaging that triggers a message to b…
christibbs 1abe348
Add button to test app that programmatically triggers a message
christibbs 6f807db
Merge branch 'master' into fiam-card-display
christibbs 518abe7
Merge branch 'master' into fiam-programmatic-triggers
christibbs d9ac27e
Add unit tests for display executor programmatic trigger flow
christibbs e03ecea
Documentation cleanup
christibbs 5ab3fc1
Merge branch 'fiam-card-display' into fiam-programmatic-triggers
christibbs ea331cf
Fix style in FIRIAMMessageContentDataWithImageURLTests.m
christibbs f719288
Add missing copyright notices
christibbs 340dc0b
Merge branch 'master' into fiam-card-display
christibbs d248d86
Bump versions of both FIAM SDKS
christibbs af666be
Remove default.profraw
christibbs 997b560
Address some logging punctuation nits. Cancel landscape image load if…
christibbs cd5ab98
Add missing error flow in image fetch. A few comment nits.
christibbs 248c877
Shorten up init method for CardDisplayMessage
christibbs b158aca
Documentation updates
christibbs 508739a
Deintegrate cocoa pods
christibbs 01cdf45
Include landscape image data in test image load class
christibbs 64d99d4
Fix Swift naming for InAppMessagingAction in UItests
christibbs 1483cf6
Remove card message initializer from public API, place into a private…
christibbs ad4fbff
Merge branch 'master' into fiam-card-display
christibbs 71b8817
Mark some properties on the card object as readonly that should've be…
christibbs 5230541
Bump dependency on InAppMessaging given changes
christibbs 1aa960a
Merge branch 'master' into fiam-card-display
christibbs 3d2c22f
Bump versions in podspecs for both SDKs
christibbs 8263366
Merge branch 'master' into fiam-card-display
christibbs 8d00b77
Make all view model properties for message subclasses readonly
christibbs c26df20
Revert changes to other message subclasses
christibbs c863e1e
Make card view model properties readonly
christibbs 689e822
Merge branch 'fiam-card-display' into fiam-programmatic-triggers
christibbs ebcb426
Run styles.sh
christibbs 6e6dde3
Merge branch 'fiam-card-display' into fiam-programmatic-triggers
christibbs 853bad6
Merge in master, fix conflicts
christibbs 8e848b6
Run styles.sh, address some comments about logging
christibbs 3ca83a6
Reuse analytic trigger method to show programmatic messages. Fix issu…
christibbs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.