Support card template display in FIAM iOS SDK #2947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dscape URLs to view model classes
paulb777
reviewed
May 14, 2019
|
Thanks! Deferring to @ryanwilson for PR approval. |
ryanwilson
reviewed
May 14, 2019
Firebase/InAppMessaging/Data/FIRIAMMessageContentDataWithImageURL.m
Outdated
Show resolved
Hide resolved
Firebase/InAppMessaging/Data/FIRIAMMessageContentDataWithImageURL.m
Outdated
Show resolved
Hide resolved
Firebase/InAppMessagingDisplay/FIDBaseRenderingViewController.m
Outdated
Show resolved
Hide resolved
… portrait image load fails.
ryanwilson
reviewed
May 14, 2019
InAppMessagingDisplay/Example/InAppMessagingDisplay-Sample.xcodeproj/project.pbxproj
Outdated
Show resolved
Hide resolved
InAppMessaging/Example/Tests/FIRIAMMessageContentDataWithImageURLTests.m
Show resolved
Hide resolved
InAppMessaging/Example/Tests/FIRIAMMessageContentDataWithImageURLTests.m
Outdated
Show resolved
Hide resolved
InAppMessaging/Example/Tests/FIRIAMMessageContentDataWithImageURLTests.m
Outdated
Show resolved
Hide resolved
InAppMessaging/Example/Tests/FIRIAMMessageContentDataWithImageURLTests.m
Outdated
Show resolved
Hide resolved
…en already, Find a way to initialize a card message in the UI tests.
|
LGTM once travis is green! Thanks for working with us on this :) |
ryanwilson
approved these changes
May 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds parsing logic and UI for a new In-App Messaging template with a card-style look.
Also makes some changes to the
FIRInAppMessagingDisplayDelegateprotocol:messageClicked:in favor ofmessageClicked:withAction:, which is necessary since the card template can have two actions and the developer may need to know which was fired.To reviewers: sorry, wasn't sure how to avoid this being one massive PR.