Skip to content

Conversation

@charlotteliang
Copy link
Contributor

Should use shouldEstablishDirectChannel property instead.

Copy link
Member

@ryanwilson ryanwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit then LGTM.

@paulb777
Copy link
Member

paulb777 commented Apr 4, 2019

Looks like this broke on travis - https://travis-ci.org/firebase/firebase-ios-sdk/builds/515808414

Copy link
Contributor

@maksymmalyhin maksymmalyhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@charlotteliang
Copy link
Contributor Author

@ryanwilson I think the PR needs your approval to be merged.

@paulb777 paulb777 dismissed ryanwilson’s stale review April 5, 2019 01:21

Ryan's nit was addressed

@charlotteliang charlotteliang merged commit f025da1 into master Apr 5, 2019
@charlotteliang charlotteliang deleted the fcm-deprecate-connect branch April 5, 2019 01:22
@firebase firebase locked and limited conversation to collaborators Oct 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants