Skip to content

Remove pendingToken from public API. #2676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2019
Merged

Remove pendingToken from public API. #2676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Firebase/Auth/Source/AuthProviders/OAuth/FIROAuthCredential_Internal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,11 @@ NS_ASSUME_NONNULL_BEGIN
*/
@property(nonatomic, readonly, nullable) NSString *sessionID;

/** @property pendingToken
@brief The pending token used when completing the headful-lite flow.
*/
@property(nonatomic, readonly, nullable) NSString *pendingToken;

/** @fn initWithProviderId:IDToken:accessToken:pendingToken
@brief Designated initializer.
@param providerID The provider ID associated with the credential being created.
Expand Down
10 changes: 0 additions & 10 deletions Firebase/Auth/Source/AuthProviders/OAuth/FIROAuthProvider.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,16 +64,6 @@ @implementation FIROAuthProvider {
NSString *_callbackScheme;
}

+ (FIROAuthCredential *)credentialWithProviderID:(NSString *)providerID
IDToken:(NSString *)IDToken
accessToken:(nullable NSString *)accessToken
pendingToken:(nullable NSString *)pendingToken {
return [[FIROAuthCredential alloc] initWithProviderID:providerID
IDToken:IDToken
accessToken:accessToken
pendingToken:pendingToken];
}

+ (FIROAuthCredential *)credentialWithProviderID:(NSString *)providerID
IDToken:(NSString *)IDToken
accessToken:(nullable NSString *)accessToken {
Expand Down
5 changes: 0 additions & 5 deletions Firebase/Auth/Source/Public/FIROAuthCredential.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,6 @@ NS_SWIFT_NAME(OAuthCredential)
*/
@property(nonatomic, readonly, nullable) NSString *accessToken;

/** @property pendingToken
@brief The pending token used when completing the headful-lite flow.
*/
@property(nonatomic, readonly, nullable) NSString *pendingToken;

/** @fn init
@brief This class is not supposed to be instantiated directly.
*/
Expand Down
16 changes: 0 additions & 16 deletions Firebase/Auth/Source/Public/FIROAuthProvider.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,22 +72,6 @@ NS_SWIFT_NAME(OAuthProvider)
*/
+ (FIROAuthProvider *)providerWithProviderID:(NSString *)providerID auth:(FIRAuth *)auth;

/** @fn credentialWithProviderID:IDToken:accessToken:
@brief Creates an `FIRAuthCredential` for that OAuth 2 provider identified by providerID, ID
token and access token.

@param providerID The provider ID associated with the Auth credential being created.
@param IDToken The IDToken associated with the Auth credential being created.
@param accessToken The accessstoken associated with the Auth credential be created, if
available.
@param pendingToken The pending token used when completing the headful-lite flow.
@return A FIRAuthCredential for the specified provider ID, ID token and access token.
*/
+ (FIROAuthCredential *)credentialWithProviderID:(NSString *)providerID
IDToken:(NSString *)IDToken
accessToken:(nullable NSString *)accessToken
pendingToken:(nullable NSString *)pendingToken;

/** @fn credentialWithProviderID:IDToken:accessToken:
@brief Creates an `FIRAuthCredential` for that OAuth 2 provider identified by providerID, ID
token and access token.
Expand Down