Skip to content

deprecate Microsoft and Yahoo Auth Provider ID #2517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 12, 2019
Merged

deprecate Microsoft and Yahoo Auth Provider ID #2517

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
883a68b
deprecate Microsoft and Yahoo Auth Provider ID
Yue-Wang-Google Mar 11, 2019
b4ef643
use DEPRECATED_MSG_ATTRIBUTE instead of deprecate attribute
Yue-Wang-Google Mar 11, 2019
2f49ed7
Revert @brief
Yue-Wang-Google Mar 11, 2019
7ffc0bb
Fix white space.
Yue-Wang-Google Mar 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Firebase/Auth/Source/Public/FIROAuthProvider.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,17 +23,17 @@

NS_ASSUME_NONNULL_BEGIN


/**
@brief A string constant identifying the Microsoft identity provider.
*/
extern NSString *const FIRMicrosoftAuthProviderID NS_SWIFT_NAME(MicrosoftAuthProviderID);
extern NSString *const FIRMicrosoftAuthProviderID NS_SWIFT_NAME(MicrosoftAuthProviderID)
DEPRECATED_MSG_ATTRIBUTE("Please use \"microsoft.com\" instead.");

/**
@brief A string constant identifying the Yahoo identity provider.
*/
extern NSString *const FIRYahooAuthProviderID NS_SWIFT_NAME(YahooAuthProviderID);

extern NSString *const FIRYahooAuthProviderID NS_SWIFT_NAME(YahooAuthProviderID)
DEPRECATED_MSG_ATTRIBUTE("Please use \"yahoo.com\" instead.");

/** @class FIROAuthProvider
@brief A concrete implementation of `FIRAuthProvider` for generic OAuth Providers.
Expand Down