Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Example/Messaging/Tests/FIRMessagingTestUtilities.m
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

#import <FirebaseAnalyticsInterop/FIRAnalyticsInterop.h>
#import <FirebaseInstanceID/FirebaseInstanceID.h>
#import <GoogleUtilities/GULUserDefaults.h>

NS_ASSUME_NONNULL_BEGIN

Expand All @@ -37,7 +38,7 @@ @interface FIRMessaging (ExposedForTest)
/// Surface internal initializer to avoid singleton usage during tests.
- (instancetype)initWithAnalytics:(nullable id<FIRAnalyticsInterop>)analytics
withInstanceID:(FIRInstanceID *)instanceID
withUserDefaults:(NSUserDefaults *)defaults;
withUserDefaults:(GULUserDefaults *)defaults;

/// Kicks off required calls for some messaging tests.
- (void)start;
Expand All @@ -46,7 +47,7 @@ - (void)start;

@implementation FIRMessagingTestUtilities

+ (FIRMessaging *)messagingForTestsWithUserDefaults:(NSUserDefaults *)userDefaults {
+ (FIRMessaging *)messagingForTestsWithUserDefaults:(GULUserDefaults *)userDefaults {
// Create the messaging instance with all the necessary dependencies.
FIRInstanceID *instanceID = [[FIRInstanceID alloc] initPrivately];
[instanceID start];
Expand Down
7 changes: 4 additions & 3 deletions Firebase/Messaging/FIRMessaging.m
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@
#import <FirebaseCore/FIRLibrary.h>
#import <FirebaseInstanceID/FirebaseInstanceID.h>
#import <GoogleUtilities/GULReachabilityChecker.h>
#import <GoogleUtilities/GULUserDefaults.h>

#import "NSError+FIRMessaging.h"

Expand Down Expand Up @@ -141,7 +142,7 @@ @interface FIRMessaging ()<FIRMessagingClientDelegate, FIRMessagingReceiverDeleg
@property(nonatomic, readwrite, strong) FIRMessagingRmqManager *rmq2Manager;
@property(nonatomic, readwrite, strong) FIRMessagingReceiver *receiver;
@property(nonatomic, readwrite, strong) FIRMessagingSyncMessageManager *syncMessageManager;
@property(nonatomic, readwrite, strong) NSUserDefaults *messagingUserDefaults;
@property(nonatomic, readwrite, strong) GULUserDefaults *messagingUserDefaults;

/// Message ID's logged for analytics. This prevents us from logging the same message twice
/// which can happen if the user inadvertently calls `appDidReceiveMessage` along with us
Expand Down Expand Up @@ -179,7 +180,7 @@ + (FIRMessaging *)messaging {

- (instancetype)initWithAnalytics:(nullable id<FIRAnalyticsInterop>)analytics
withInstanceID:(FIRInstanceID *)instanceID
withUserDefaults:(NSUserDefaults *)defaults {
withUserDefaults:(GULUserDefaults *)defaults {
self = [super init];
if (self != nil) {
_loggedMessageIDs = [NSMutableSet set];
Expand Down Expand Up @@ -214,7 +215,7 @@ + (void)load {
id<FIRAnalyticsInterop> analytics = FIR_COMPONENT(FIRAnalyticsInterop, container);
return [[FIRMessaging alloc] initWithAnalytics:analytics
withInstanceID:[FIRInstanceID instanceID]
withUserDefaults:[NSUserDefaults standardUserDefaults]];
withUserDefaults:[GULUserDefaults standardUserDefaults]];
};
FIRComponent *messagingProvider =
[FIRComponent componentWithProtocol:@protocol(FIRMessagingInstanceProvider)
Expand Down
6 changes: 4 additions & 2 deletions Firebase/Messaging/FIRMessagingPubSub.m
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@

#import "FIRMessagingPubSub.h"

#import <GoogleUtilities/GULUserDefaults.h>

#import "FIRMessaging.h"
#import "FIRMessagingClient.h"
#import "FIRMessagingDefines.h"
Expand Down Expand Up @@ -186,14 +188,14 @@ - (BOOL)pendingTopicsListCanRequestTopicUpdates:(FIRMessagingPendingTopicsList *
#pragma mark - Storing Pending Topics

- (void)archivePendingTopicsList:(FIRMessagingPendingTopicsList *)topicsList {
NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
GULUserDefaults *defaults = [GULUserDefaults standardUserDefaults];
NSData *pendingData = [NSKeyedArchiver archivedDataWithRootObject:topicsList];
[defaults setObject:pendingData forKey:kPendingSubscriptionsListKey];
[defaults synchronize];
}

- (void)restorePendingTopicsList {
NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
GULUserDefaults *defaults = [GULUserDefaults standardUserDefaults];
NSData *pendingData = [defaults objectForKey:kPendingSubscriptionsListKey];
FIRMessagingPendingTopicsList *subscriptions;
@try {
Expand Down
3 changes: 2 additions & 1 deletion Firebase/Messaging/FIRMessagingReceiver.h
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
NS_ASSUME_NONNULL_BEGIN

@class FIRMessagingReceiver;
@class GULUserDefaults;
@protocol FIRMessagingReceiverDelegate <NSObject>

- (void)receiver:(FIRMessagingReceiver *)receiver
Expand All @@ -30,7 +31,7 @@ NS_ASSUME_NONNULL_BEGIN
@interface FIRMessagingReceiver : NSObject <FIRMessagingDataMessageManagerDelegate>

/// Default initializer for creating the messaging receiver.
- (instancetype)initWithUserDefaults:(NSUserDefaults *)defaults NS_DESIGNATED_INITIALIZER;
- (instancetype)initWithUserDefaults:(GULUserDefaults *)defaults NS_DESIGNATED_INITIALIZER;

/// Use `initWithUserDefaults:` instead.
- (instancetype)init NS_UNAVAILABLE;
Expand Down
5 changes: 3 additions & 2 deletions Firebase/Messaging/FIRMessagingReceiver.m
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
#import <UIKit/UIKit.h>

#import <GoogleUtilities/GULAppEnvironmentUtil.h>
#import <GoogleUtilities/GULUserDefaults.h>

#import "FIRMessaging.h"
#import "FIRMessagingLogger.h"
Expand All @@ -37,14 +38,14 @@
static int downstreamMessageID = 0;

@interface FIRMessagingReceiver ()
@property(nonatomic, strong) NSUserDefaults *defaults;
@property(nonatomic, strong) GULUserDefaults *defaults;
@end

@implementation FIRMessagingReceiver

#pragma mark - Initializer

- (instancetype)initWithUserDefaults:(NSUserDefaults *)defaults {
- (instancetype)initWithUserDefaults:(GULUserDefaults *)defaults {
self = [super init];
if (self != nil) {
_defaults = defaults;
Expand Down
5 changes: 3 additions & 2 deletions FirebaseMessaging.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@ device, and it is completely free.
s.dependency 'FirebaseAnalyticsInterop', '~> 1.1'
s.dependency 'FirebaseCore', '~> 5.2'
s.dependency 'FirebaseInstanceID', '~> 3.6'
s.dependency 'GoogleUtilities/Reachability', '~> 5.2'
s.dependency 'GoogleUtilities/Environment', '~> 5.2'
s.dependency 'GoogleUtilities/Reachability', '~> 5.3'
s.dependency 'GoogleUtilities/Environment', '~> 5.3'
s.dependency 'GoogleUtilities/UserDefaults', '~> 5.3'
s.dependency 'Protobuf', '~> 3.1'
end