Skip to content

Be sure to validate return code when calling sysctlbyname function (C… #2394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 21, 2019
Merged

Be sure to validate return code when calling sysctlbyname function (C… #2394

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9051008
Be sure to validate return code when calling sysctlbyname function (C…
Feb 14, 2019
819a553
Fix whitespace
Feb 14, 2019
f4449f4
Fix code style
Feb 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions Firebase/DynamicLinks/Utilities/FDLUtilities.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,11 +169,16 @@ BOOL FIRDLOSVersionSupported(NSString *_Nullable systemVersion, NSString *minSup
static dispatch_once_t onceToken;
dispatch_once(&onceToken, ^{
size_t size;
sysctlbyname("hw.machine", NULL, &size, NULL, 0);
char *machine = calloc(1, size);
sysctlbyname("hw.machine", machine, &size, NULL, 0);
machineString = [NSString stringWithCString:machine encoding:NSUTF8StringEncoding];
free(machine);

// compute string size
if (sysctlbyname("hw.machine", NULL, &size, NULL, 0) == 0) {
// get device name
char *machine = calloc(1, size);
if (sysctlbyname("hw.machine", machine, &size, NULL, 0) == 0) {
machineString = [NSString stringWithCString:machine encoding:NSUTF8StringEncoding];
}
free(machine);
}
});
return machineString;
}
Expand Down