Skip to content

Fix bad JWT parsing #1448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2018
Merged

Fix bad JWT parsing #1448

merged 1 commit into from
Jun 25, 2018

Conversation

@morganchen12
Copy link
Contributor

@morganchen12 morganchen12 commented Jun 25, 2018

Fixes #1319.

@morganchen12 morganchen12 requested a review from protocol86 June 25, 2018 21:31
@morganchen12 morganchen12 mentioned this pull request Jun 25, 2018
Merged
protocol86
protocol86 approved these changes Jun 25, 2018
View reviewed changes
Copy link
Contributor

@protocol86 protocol86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks.

@morganchen12 morganchen12 merged commit 14dd9dc into firebase:master Jun 25, 2018
@morganchen12 morganchen12 deleted the auth3 branch June 25, 2018 21:48
@firebase firebase locked and limited conversation to collaborators Oct 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@protocol86 protocol86 protocol86 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: auth cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

FIRUser decode of dates is incorrect.

3 participants

@morganchen12 @protocol86 @googlebot