Skip to content

[Vertex AI] Fix CountTokensResponse decoding #14447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 11, 2025
Merged

[Vertex AI] Fix CountTokensResponse decoding #14447

merged 2 commits into from
Feb 11, 2025

Conversation

@andrewheard
Copy link
Contributor

@andrewheard andrewheard commented Feb 11, 2025

Fixed a decoding issue in CountTokensResponse. This needs a custom decoder now to handle the case when promptTokensDetails is nil.

#no-changelog

@andrewheard andrewheard marked this pull request as ready for review February 11, 2025 22:22
@andrewheard andrewheard merged commit 9b16e48 into main Feb 11, 2025
38 checks passed
@andrewheard andrewheard deleted the ah/vertex-count-decoding branch February 11, 2025 22:27
@github-actions github-actions bot mentioned this pull request Feb 26, 2025
Merged
@firebase firebase locked and limited conversation to collaborators Mar 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@paulb777 paulb777 paulb777 approved these changes

@rlazo rlazo Awaiting requested review from rlazo

Assignees

No one assigned

Labels

api: firebaseai

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andrewheard @paulb777