Skip to content

Firestore: Improve efficiency of memory persistence when processing a large number of writes #13572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 4, 2024
Merged

Firestore: Improve efficiency of memory persistence when processing a large number of writes #13572

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
192778f
memory_mutation_queue.h: use deque instead of vector for more efficie…
dconeybe Sep 3, 2024
77591ac
Firestore/CHANGELOG.md: add entry
dconeybe Sep 3, 2024
a7c9f91
Firestore/CHANGELOG.md: update PR number
dconeybe Sep 3, 2024
04ef4f7
Merge remote-tracking branch 'origin/main' into MemoryMutationQueueDeque
dconeybe Sep 4, 2024
ec96602
Merge remote-tracking branch 'origin/main' into MemoryMutationQueueDeque
dconeybe Sep 4, 2024
ac5c2d9
memory_mutation_queue.h: actually change the data type from vector to…
dconeybe Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Firestore/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# Unreleased
- [changed] Improve efficiency of memory persistence when processing a large number of writes. (#13572)

# 11.2.0
- [fixed] Marked all public classes with only readonly properties as `Sendable` to address
Swift Concurrency Check warning. (#12666)
Expand Down
5 changes: 3 additions & 2 deletions Firestore/core/src/local/memory_mutation_queue.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
#ifndef FIRESTORE_CORE_SRC_LOCAL_MEMORY_MUTATION_QUEUE_H_
#define FIRESTORE_CORE_SRC_LOCAL_MEMORY_MUTATION_QUEUE_H_

#include <deque>
#include <set>
#include <vector>

Expand Down Expand Up @@ -59,7 +60,7 @@ class MemoryMutationQueue : public MutationQueue {
void RemoveMutationBatch(const model::MutationBatch& batch) override;

std::vector<model::MutationBatch> AllMutationBatches() override {
return queue_;
return std::vector<model::MutationBatch>(queue_.begin(), queue_.end());
}

std::vector<model::MutationBatch> AllMutationBatchesAffectingDocumentKeys(
Expand Down Expand Up @@ -128,7 +129,7 @@ class MemoryMutationQueue : public MutationQueue {
* Once the held write acknowledgements become visible they are removed from
* the head of the queue along with any tombstones that follow.
*/
std::vector<model::MutationBatch> queue_;
std::deque<model::MutationBatch> queue_;

/**
* The next value to use when assigning sequential IDs to each mutation
Expand Down