Skip to content

[Firestore] Remove DocumentID setter warning #12756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2024
Merged

[Firestore] Remove DocumentID setter warning #12756

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e3a33d
[Firestore] Remove DocumentID setter warning
andrewheard Apr 11, 2024
deb52b2
Add CHANGELOG entry
andrewheard Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Firestore/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
# Unreleased
- [changed] Passing a non-nil value to the `@DocumentID` property wrapper's
setter no longer logs a warning since it discouraged valid patterns,
e.g., updating the document ID after the document is created in Firestore. (#12756)

# 10.24.0
- [feature] Enable queries with range & inequality filters on multiple fields. (#12416)

Expand Down
7 changes: 1 addition & 6 deletions Firestore/Swift/Source/Codable/DocumentID.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,12 +121,7 @@ public struct DocumentID<Value: DocumentIDWrappable & Codable>:

public var wrappedValue: Value? {
get { value }
set {
if let someNewValue = newValue {
logIgnoredValueWarning(value: someNewValue)
}
value = newValue
}
set { value = newValue }
}

private func logIgnoredValueWarning(value: Value) {
Expand Down