Skip to content

[Firestore] Add warning when building Firestore's binary SPM distro for visionOS #12279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 16, 2024
Merged

[Firestore] Add warning when building Firestore's binary SPM distro for visionOS #12279

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
bf12567
[Firestore] Add warnings when building Firestore's binary SPM distro …
ncooke3 Jan 15, 2024
3dd7633
Appease package loading stage and move warning
ncooke3 Jan 16, 2024
69d22a9
Add changelog entry
ncooke3 Jan 16, 2024
0361910
style
ncooke3 Jan 16, 2024
1339da6
Style
ncooke3 Jan 16, 2024
a79bae3
Review
ncooke3 Jan 16, 2024
683a33a
Review (2)
ncooke3 Jan 16, 2024
4b38563
Switch from `#warning` to `#error`
andrewheard Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Firestore/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
# Unreleased
- Add warning when trying to build Firestore's binary SPM distribution for
visionOS (#12279). See Firestore's 10.12.0 release note for supported
workaround.

# 10.19.0
- [fixed] Made an optimization to the synchronization logic for resumed queries
to only re-download locally-cached documents that are known to be out-of-sync. (#12044)
Expand Down
20 changes: 16 additions & 4 deletions Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1364,7 +1364,8 @@ func firestoreWrapperTarget() -> Target {
name: "FirebaseFirestoreTarget",
dependencies: [.target(name: "FirebaseFirestore",
condition: .when(platforms: [.iOS, .tvOS, .macOS, .macCatalyst]))],
path: "SwiftPM-PlatformExclude/FirebaseFirestoreWrap"
path: "SwiftPM-PlatformExclude/FirebaseFirestoreWrap",
cSettings: [.define("FIREBASE_BINARY_FIRESTORE", to: "1")]
)
}

Expand Down Expand Up @@ -1494,8 +1495,16 @@ func firestoreTargets() -> [Target] {
name: "FirebaseFirestoreInternalWrapper",
condition: .when(platforms: [.iOS, .macCatalyst, .tvOS, .macOS])
),
.product(name: "abseil", package: "abseil-cpp-binary"),
.product(name: "gRPC-C++", package: "grpc-binary"),
.product(
name: "abseil",
package: "abseil-cpp-binary",
condition: .when(platforms: [.iOS, .macCatalyst, .tvOS, .macOS])
),
.product(
name: "gRPC-C++",
package: "grpc-binary",
condition: .when(platforms: [.iOS, .macCatalyst, .tvOS, .macOS])
),
.product(name: "nanopb", package: "nanopb"),
"FirebaseAppCheckInterop",
"FirebaseCore",
Expand All @@ -1512,7 +1521,10 @@ func firestoreTargets() -> [Target] {
),
.target(
name: "FirebaseFirestoreInternalWrapper",
dependencies: ["FirebaseFirestoreInternal"],
dependencies: [.target(
name: "FirebaseFirestoreInternal",
condition: .when(platforms: [.iOS, .macCatalyst, .tvOS, .macOS])
)],
path: "FirebaseFirestoreInternal",
publicHeadersPath: "."
),
Expand Down
6 changes: 6 additions & 0 deletions SwiftPM-PlatformExclude/FirebaseFirestoreWrap/dummy.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,9 @@
#if TARGET_OS_WATCH
#warning "Firebase Firestore does not support watchOS"
#endif

#if (defined(TARGET_OS_VISION) && TARGET_OS_VISION) && FIREBASE_BINARY_FIRESTORE
#warning "Firebase Firestore's binary SPM distribution does not support \
visionOS. See workaround documented in the 10.12.0 release notes: \
https://firebase.google.com/support/release-notes/ios#version_10120_-_july_11_2023"
#endif