Skip to content

Update cmake dependency for GoogleUtilities to 7.12.0 #12069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2023
Merged

Update cmake dependency for GoogleUtilities to 7.12.0 #12069

merged 1 commit into from
Nov 8, 2023

Conversation

@andrewheard
Copy link
Contributor

@andrewheard andrewheard commented Nov 7, 2023

Updated the cmake GoogleUtilities dependency to 7.12.0 since FirebaseCore updated to this version in #12059.

#no-changelog

@andrewheard andrewheard mentioned this pull request Nov 7, 2023
Merged
@andrewheard andrewheard added this to the 10.18.0 - M140 milestone Nov 7, 2023
@andrewheard andrewheard requested a review from paulb777 November 7, 2023 23:17
@google-oss-bot
Copy link

google-oss-bot commented Nov 7, 2023

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestoreInternal.framework

    Overall coverage changed from 88.15% (afca289) to 88.10% (22940af) by -0.05%.

    FilenameBase (afca289)Merge (22940af)Diff
    exception.cc84.21%23.68%-60.53%
    leveldb_key.cc98.14%98.82%+0.69%
    ordered_code.cc93.90%94.39%+0.49%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/YA4SFvIGkv.html

@andrewheard andrewheard mentioned this pull request Nov 7, 2023
Closed
@andrewheard
Copy link
Contributor Author

andrewheard commented Nov 7, 2023

The firestore / cmake workflows are existing failures (#12058, #12070).

@andrewheard andrewheard merged commit 8329c4c into master Nov 8, 2023
@andrewheard andrewheard deleted the ah/gul-cmake branch November 8, 2023 00:04
@firebase firebase locked and limited conversation to collaborators Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

10.18.0 - M140

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewheard @google-oss-bot @paulb777