Skip to content

Fix Firestore visionOS build on Xcode 15.1 #12029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 31, 2023
Merged

Fix Firestore visionOS build on Xcode 15.1 #12029

merged 2 commits into from
Oct 31, 2023

Conversation

@paulb777
Copy link
Member

@paulb777 paulb777 commented Oct 31, 2023

Fix #12023

ncooke3
ncooke3 approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm in the process of staging pods in case there are some unrelated CI failures.

@google-oss-bot
Copy link

google-oss-bot commented Oct 31, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestoreInternal.framework

    Overall coverage changed from 88.15% (b850d1a) to 88.17% (895ea96) by +0.02%.

    FilenameBase (b850d1a)Merge (895ea96)Diff
    connectivity_monitor_apple.mm51.92%52.83%+0.91%
    filesystem_apple.mm83.33%83.78%+0.45%
    leveldb_key.cc98.14%98.33%+0.20%
    write_stream.cc91.55%94.37%+2.82%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/EWUBr18tKy.html

@paulb777 paulb777 merged commit 822f547 into master Oct 31, 2023
@paulb777 paulb777 deleted the pb-fs-xc151-vision branch October 31, 2023 20:30
@firebase firebase locked and limited conversation to collaborators Dec 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ncooke3 ncooke3 ncooke3 approved these changes

Assignees

No one assigned

Labels

api: firestore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Don't know where to store documents on visionOS.

3 participants

@paulb777 @google-oss-bot @ncooke3