Skip to content

Fix a regression of a memory leak in Sessions. #11802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 29, 2023
Merged

Fix a regression of a memory leak in Sessions. #11802

merged 4 commits into from
Sep 29, 2023

Conversation

@morganchen12
Copy link
Contributor

@morganchen12 morganchen12 commented Sep 12, 2023 •
edited
Loading

This is a regression of #11027. Fixes #11725.

@google-oss-bot
Copy link

google-oss-bot commented Sep 12, 2023

Coverage Report 1

Affected Products

  • FirebasePerformance-iOS-FirebasePerformance.framework

    Overall coverage changed from 94.69% (418c9cc) to 94.79% (d16efb5) by +0.10%.

    FilenameBase (418c9cc)Merge (d16efb5)Diff
    FPRClient.m94.49%95.28%+0.79%
    FPRGaugeManager.m95.42%97.39%+1.96%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/2Nddt0xt3L.html

paulb777
paulb777 approved these changes Sep 29, 2023
View reviewed changes
@morganchen12 morganchen12 merged commit 7ebb280 into master Sep 29, 2023
@morganchen12 morganchen12 deleted the mc/leak branch September 29, 2023 21:16
@firebase firebase locked and limited conversation to collaborators Oct 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@andrewheard andrewheard andrewheard left review comments

@paulb777 paulb777 paulb777 approved these changes

@themiswang themiswang themiswang approved these changes

@samedson samedson Awaiting requested review from samedson

Assignees

No one assigned

Labels

api: crashlytics api: performance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Firebase Crashlytics and Performance causes a memory leak at app launch.

5 participants

@morganchen12 @google-oss-bot @paulb777 @andrewheard @themiswang