-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add reCAPTCHA support to email flows of sign up, send email link, reset password #11446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Generated by 🚫 Danger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm except for one comment about action string.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except for one comment about recaptchaClient and recaptchaVersion fields
Note that most of the code are duplicated from the email password sign in flow. Was trying to create a shared helper method but didn't find a good way due to the callback mechanism. Will try to simplify it with async/await after migrate to swift.