Skip to content

Conversation

@renkelvin
Copy link
Contributor

@renkelvin renkelvin commented Jun 16, 2023

Note that most of the code are duplicated from the email password sign in flow. Was trying to create a shared helper method but didn't find a good way due to the callback mechanism. Will try to simplify it with async/await after migrate to swift.

@renkelvin renkelvin changed the base branch from master to recaptcha June 16, 2023 01:48
@renkelvin renkelvin marked this pull request as ready for review June 16, 2023 01:48
@renkelvin renkelvin changed the title Email flows [WIP] Email flows Jun 16, 2023
@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@renkelvin renkelvin changed the title [WIP] Email flows Add reCAPTCHA support to email flows of sign up, send email link, reset password Jun 20, 2023
@renkelvin renkelvin requested review from paulb777 and prameshj June 20, 2023 16:44
Copy link

@prameshj prameshj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm except for one comment about action string.

Copy link

@prameshj prameshj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for one comment about recaptchaClient and recaptchaVersion fields

@renkelvin renkelvin merged commit 9424622 into recaptcha Jul 18, 2023
@renkelvin renkelvin deleted the email-flows branch July 18, 2023 19:02
@firebase firebase locked and limited conversation to collaborators Aug 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants