Skip to content

Conversation

@andrewheard
Copy link
Contributor

The constants in GACAppCheckLogger conflict with those in FIRAppCheckLogger.

#no-changelog

The constants in `GACAppCheckLogger` conflict with those in
`FIRAppCheckLogger`.
@andrewheard
Copy link
Contributor Author

This addresses one of the issues found in PR #11375 (not yet ready for review).

@andrewheard andrewheard marked this pull request as ready for review June 1, 2023 21:48
@andrewheard andrewheard requested a review from paulb777 June 1, 2023 21:48
@andrewheard andrewheard merged commit 256f5f0 into appcheck-lite Jun 2, 2023
@andrewheard andrewheard deleted the ah/appcheck-symbols branch June 2, 2023 15:27
andrewheard added a commit that referenced this pull request Jun 6, 2023
commit be8e01f
Author: Andrew Heard <andrewheard@google.com>
Date:   Tue Jun 6 13:05:11 2023 -0400

    Fix integration tests `source_files`

commit af314f8
Author: Andrew Heard <andrewheard@google.com>
Date:   Tue Jun 6 11:05:25 2023 -0400

    Remove AppCheckInterop headers from AppCheck SDK

    Removed the headers in `AppCheck/Interop` from the App Check SDK
    `source_files`.

commit 256f5f0
Author: Andrew Heard <andrewheard@google.com>
Date:   Fri Jun 2 11:27:12 2023 -0400

    [App Check] Rename symbols in GACAppCheckLogger (#11381)

    The constants in `GACAppCheckLogger` conflict with those in `FIRAppCheckLogger`.
andrewheard added a commit that referenced this pull request Jun 13, 2023
The constants in `GACAppCheckLogger` conflict with those in `FIRAppCheckLogger`.
@firebase firebase locked and limited conversation to collaborators Jul 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants