[App Check] Remove Firebase specifics from Device Check Provider #11352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed Firebase-specific symbols and implementation details from the generic Device Check Provider (GACDeviceCheckProvider).
andrewheard
force-pushed
the
ah/devicecheck-lite
branch
from
1c0f4b1 to
eff699e
Compare
|
Rebased on |
paulb777
approved these changes
May 30, 2023
Removed `#if compiler(>=5.5.2) && canImport(_Concurrency)` checks since we only support Xcode 14.1+, which includes Swift 5.7.1.
Replaced "macOS 11.15" with "macOS 10.15" (i.e., Catalina) in AppCheckAPITests.swift.
andrewheard
added a commit
that referenced
this pull request
May 31, 2023
Removed Firebase-specific symbols and implementation details from the generic Device Check Provider (GACDeviceCheckProvider).
andrewheard
added a commit
that referenced
this pull request
Jun 13, 2023
Removed Firebase-specific symbols and implementation details from the generic Device Check Provider (GACDeviceCheckProvider).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed Firebase-specific symbols and implementation details from the generic Device Check Provider (
GACDeviceCheckProvider).#no-changelog