Skip to content

Conversation

@sunmou99
Copy link
Contributor

@sunmou99 sunmou99 commented May 16, 2023

A minor bug in the API diff. The report here should be showing HTTPSCallableOptions as a new class: #11270 (comment)

Fix: Print out the class name as title.
e.g.

FirebaseFunctions

Classes

Functions
[ADDED] httpsCallable(_:options:)
Swift:
+  @objc(HTTPSCallableWithURL:options:) public func httpsCallable ( _ url : URL , options : HTTPSCallableOptions ) -> HTTPSCallable
[ADDED] httpsCallable(_:options:requestAs:responseAs:encoder:decoder:)
Swift:
+  open func httpsCallable < Request : Encodable , Response : Decodable > ( _ url : URL , options : HTTPSCallableOptions , requestAs : Request . Type = Request . self , responseAs : Response . Type = Response . self , encoder : FirebaseDataEncoder = FirebaseDataEncoder ( ), decoder : FirebaseDataDecoder = FirebaseDataDecoder ( )) -> Callable < Request , Response >
[ADDED] HTTPSCallableOptions
[ADDED] HTTPSCallableOptions
Swift:
+  @objc(FIRHTTPSCallableOptions) public class HTTPSCallableOptions : NSObject
+    @objc public let requireLimitedUseAppCheckTokens : Bool
+    @objc public init ( requireLimitedUseAppCheckTokens : Bool )

@sunmou99 sunmou99 requested a review from ncooke3 May 16, 2023 17:49
@sunmou99 sunmou99 merged commit 5504b40 into master May 16, 2023
@sunmou99 sunmou99 deleted the fix-api-diff-class-name branch May 16, 2023 18:22
@firebase firebase locked and limited conversation to collaborators Jun 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants