Extract heartbeat logger from GACAppCheckAPIService #11277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the direct dependency on FIRHeartbeatLoggerProtocol from GACAppCheckAPIService, moving it up into the App Check providers. Added request hooks (blocks) to allow heartbeat logging headers to be added to requests before they are sent.
paulb777
approved these changes
May 11, 2023
| GACAppAttestKeyIDStorage *keyIDStorage = | ||
| [[GACAppAttestKeyIDStorage alloc] initWithAppName:app.name appID:app.options.googleAppID]; | ||
|
|
||
| GACAppCheckAPIRequestHook heartbeatLoggerHook = ^(NSMutableURLRequest *request) { |
There was a problem hiding this comment.
This is temporary also, right?
There was a problem hiding this comment.
Yep, thanks for catching! I just added some comments around these code blocks in each of the existing providers so they don't get missed.
Note: The request hooks concept will likely remain (or some alternative approach) but I'll need to pass them in from the Firebase App Check SDK since the generic App Check SDK shouldn't know about FIRHeartbeatLoggerProtocol once we're done refactoring (these code blocks themselves are temporary though).
Surrounded Firebase-specific code with FIREBASE_APP_CHECK_ONLY_BEGIN and FIREBASE_APP_CHECK_ONLY_END comments.
andrewheard
added a commit
that referenced
this pull request
May 19, 2023
Removed the direct dependency on FIRHeartbeatLoggerProtocol from GACAppCheckAPIService, moving it up into the App Check providers. Added request hooks (blocks) to allow heartbeat logging headers to be added to requests before they are sent.
andrewheard
added a commit
that referenced
this pull request
May 26, 2023
Removed the direct dependency on FIRHeartbeatLoggerProtocol from GACAppCheckAPIService, moving it up into the App Check providers. Added request hooks (blocks) to allow heartbeat logging headers to be added to requests before they are sent.
andrewheard
added a commit
that referenced
this pull request
May 31, 2023
Removed the direct dependency on FIRHeartbeatLoggerProtocol from GACAppCheckAPIService, moving it up into the App Check providers. Added request hooks (blocks) to allow heartbeat logging headers to be added to requests before they are sent.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the direct dependency on
FIRHeartbeatLoggerProtocolfromGACAppCheckAPIService, moving it up into the App Check providers.Added request hooks (blocks) to allow heartbeat logging headers to be added to requests before they are sent.
#no-changelog