Add @discardableResult to async addDocument
#11151
Merged
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
peterfriese
approved these changes
Apr 20, 2023
|
@peterfriese Thank you. I have already signed the CLA. https://github.com/firebase/firebase-ios-sdk/pull/11151/checks?check_run_id=12882758677 |
ncooke3
added a commit
that referenced
this pull request
Apr 20, 2023
ncooke3
added a commit
that referenced
this pull request
Apr 20, 2023
ncooke3
added a commit
that referenced
this pull request
Apr 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10640
I would like to propose a Pull Request to add the
@discardableResultattribute to the asyncaddDocumentmethod in CollectionReference. This change would be consistent with the similar change made in PR #10661.