[Release] Enable macCatalyst support for Firestore targets #11121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulb777
reviewed
Apr 13, 2023
|
@paulb777, I think so. I was going to investigate after getting the patch out but I could do that now. |
|
weirdly, testing the |
paulb777
approved these changes
Apr 13, 2023
ncooke3
added a commit
that referenced
this pull request
Apr 13, 2023
* [Release] Update Package.swift for 10.8.1 release * Update changelog entry for 10.8.1 Package.swift
ncooke3
added a commit
that referenced
this pull request
Apr 13, 2023
* [Release] Enable macCatalyst support for Firestore targets (#11121) * [Release] Update Package.swift for 10.8.1 release * Update changelog entry for 10.8.1 Package.swift * [Release] Bump package version in Package.swift
Xiaoshouzi-gh
added a commit
that referenced
this pull request
Apr 14, 2023
* [Infra] Avoid subshells in test script (#11094) * [Auth] Remove unreachable code (#11091) * [Auth] Remove unreachable code * Rename '-[FIRAuthStoredUserManager getStoredUserAccessGroupWithError:]' * Favor 'NULL' over 'nil' for a ** * Rename '-[FIRAuthStoredUserManager setStoredUserAccessGroup:error:]' * [Tooling] Add FIR_CLANG_FORMAT_PATH env var to style.sh (#11097) Added an environment variable to specify the path to the version of clang-format used by the style.sh script. * Carthage json updates for 10.8.0 (#11103) * Update versions for Release 10.9.0 (#11112) * [RemoteConfig] Expose NSUnderlyingError to client (#11102) * [Release Tooling] Separate out dynamic content from zip README.md (#11113) * Updated README Badges (#11117) * [Release] Enable macCatalyst support for Firestore targets (#11121) * [Release] Update Package.swift for 10.8.1 release * Update changelog entry for 10.8.1 Package.swift * New Cache Config API (#11057) --------- Co-authored-by: Nick Cooke <36927374+ncooke3@users.noreply.github.com> Co-authored-by: Andrew Heard <andrewheard@google.com> Co-authored-by: Paul Beusterien <paulbeusterien@google.com> Co-authored-by: Guglielmo Faglioni <guglielmo@gorillatech.io> Co-authored-by: Max Cobb <5754073+maxxfrazer@users.noreply.github.com> Co-authored-by: wu-hui <53845758+wu-hui@users.noreply.github.com>
pragatimodi
added a commit
that referenced
this pull request
Apr 14, 2023
* [Infra] Avoid subshells in test script (#11094) * [Auth] Remove unreachable code (#11091) * [Auth] Remove unreachable code * Rename '-[FIRAuthStoredUserManager getStoredUserAccessGroupWithError:]' * Favor 'NULL' over 'nil' for a ** * Rename '-[FIRAuthStoredUserManager setStoredUserAccessGroup:error:]' * [Tooling] Add FIR_CLANG_FORMAT_PATH env var to style.sh (#11097) Added an environment variable to specify the path to the version of clang-format used by the style.sh script. * Carthage json updates for 10.8.0 (#11103) * Update versions for Release 10.9.0 (#11112) * [RemoteConfig] Expose NSUnderlyingError to client (#11102) * [Release Tooling] Separate out dynamic content from zip README.md (#11113) * Updated README Badges (#11117) * [Release] Enable macCatalyst support for Firestore targets (#11121) * [Release] Update Package.swift for 10.8.1 release * Update changelog entry for 10.8.1 Package.swift * New Cache Config API (#11057) * Fix bundle query resume bug (#11018) * Fix bundle query resume bug * fix * Update for proposed g3 ocmock changes (#11116) --------- Co-authored-by: Nick Cooke <36927374+ncooke3@users.noreply.github.com> Co-authored-by: Andrew Heard <andrewheard@google.com> Co-authored-by: Paul Beusterien <paulbeusterien@google.com> Co-authored-by: Guglielmo Faglioni <guglielmo@gorillatech.io> Co-authored-by: Max Cobb <5754073+maxxfrazer@users.noreply.github.com> Co-authored-by: wu-hui <53845758+wu-hui@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
After this merges, I'll create the release branch and cherry-pick this into it.