Skip to content

Add Storage API to limit upload chunk size #10609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 25, 2023
Merged

Add Storage API to limit upload chunk size #10609

merged 4 commits into from
Jan 25, 2023

Conversation

@paulb777
Copy link
Member

@paulb777 paulb777 commented Dec 22, 2022 •
edited
Loading

Fix #10137

Googlers: API proposal at go/firebase-storage-chunk-size

@firebase firebase deleted a comment from google-oss-bot Dec 22, 2022
@paulb777
Copy link
Member Author

paulb777 commented Dec 22, 2022

@maneesht Let me know what you think and I can write up an API proposal.

@maneesht
Copy link
Contributor

maneesht commented Jan 3, 2023

@maneesht Let me know what you think and I can write up an API proposal.

LGTM

charlotteliang
charlotteliang reviewed Jan 13, 2023
View reviewed changes
@google-oss-bot
Copy link

google-oss-bot commented Jan 17, 2023

Coverage Report 1

Affected Products

  • FirebaseStorage-iOS-FirebaseStorage.framework

    Overall coverage changed from ? (92eebaf) to 0.00% (2e39605) by ?.

    21 individual files with coverage change

    FilenameBase (92eebaf)Merge (2e39605)Diff
    AsyncAwait.swift?0.00%?
    Result.swift?0.00%?
    Storage.swift?0.00%?
    StorageComponent.swift?0.00%?
    StorageDeleteTask.swift?0.00%?
    StorageDownloadTask.swift?0.00%?
    StorageError.swift?0.00%?
    StorageGetDownloadURLTask.swift?0.00%?
    StorageGetMetadataTask.swift?0.00%?
    StorageListResult.swift?0.00%?
    StorageListTask.swift?0.00%?
    StorageMetadata.swift?0.00%?
    StorageObservableTask.swift?0.00%?
    StoragePath.swift?0.00%?
    StorageReference.swift?0.00%?
    StorageTask.swift?0.00%?
    StorageTaskSnapshot.swift?0.00%?
    StorageTokenAuthorizer.swift?0.00%?
    StorageUpdateMetadataTask.swift?0.00%?
    StorageUploadTask.swift?0.00%?
    StorageUtils.swift?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/hyQGMWRtia.html

charlotteliang
charlotteliang approved these changes Jan 18, 2023
View reviewed changes
charlotteliang
charlotteliang approved these changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@charlotteliang charlotteliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@paulb777 paulb777 merged commit 66f23d5 into master Jan 25, 2023
@paulb777 paulb777 deleted the pb-chunk branch January 25, 2023 17:49
@firebase firebase locked and limited conversation to collaborators Feb 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@maneesht maneesht maneesht left review comments

@charlotteliang charlotteliang charlotteliang approved these changes

Assignees

@maneesht maneesht

Labels

api: storage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FR]: Set chunk size on upload task

4 participants

@paulb777 @maneesht @google-oss-bot @charlotteliang