Skip to content

Make App Distribution compatible with swizzling-disabled implementations #10418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 31, 2022
Merged

Make App Distribution compatible with swizzling-disabled implementations #10418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
41fe302
Revert "Include subheaders in script output (#10212)"
morganchen12 Oct 25, 2022
dbec7af
make app distro swizzling compatible
morganchen12 Oct 28, 2022
b9555bb
add changelog
morganchen12 Oct 28, 2022
e4f94fd
fix build
morganchen12 Oct 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions FirebaseAppDistribution/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# Unreleased
- [added] Added a public `application(_:openURL:options:)` method so users
with swizzling disabled can still use App Distribution (#10418).

# 10.1.0
- [fixed] Fixed inconsistent sign in prompts in single scene apps (#8096).

Expand Down
9 changes: 9 additions & 0 deletions FirebaseAppDistribution/Sources/FIRAppDistribution.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,4 +336,13 @@ - (BOOL)isCodeHashIdentical:(NSString *)codeHash {

return codeHash && [codeHash isEqualToString:[machO codeHash]];
}

#pragma mark - Swizzling disabled

- (BOOL)application:(UIApplication *)application
openURL:(NSURL *)url
options:(NSDictionary<NSString *, id> *)options {
return [self.uiService application:application openURL:url options:options];
}

@end
4 changes: 1 addition & 3 deletions FirebaseAppDistribution/Sources/FIRAppDistributionUIService.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,9 +179,7 @@ - (BOOL)application:(UIApplication *)application
if (self.registrationFlowCompletion) {
FIRFADDebugLog(@"Continuing registration flow: %@", [self registrationFlowCompletion]);
[self resetUIState];
if (@available(iOS 9.0, *)) {
[self logRegistrationCompletion:nil authType:[SFSafariViewController description]];
}
[self logRegistrationCompletion:nil authType:[SFSafariViewController description]];
self.registrationFlowCompletion(nil);
}
return NO;
Expand Down
9 changes: 9 additions & 0 deletions FirebaseAppDistribution/Sources/Public/FirebaseAppDistribution/FIRAppDistribution.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
// limitations under the License.

@class FIRAppDistributionRelease;
@class UIApplication;
#import <Foundation/Foundation.h>

NS_ASSUME_NONNULL_BEGIN
Expand Down Expand Up @@ -55,6 +56,14 @@ NS_SWIFT_NAME(AppDistribution)
*/
- (void)signOutTester;

/**
* Handle an App Distribution URL, for example a link to download a new pre-release version.
* Call this method in your app delegate's `openURL` implementation if swizzling is disabled.
*/
- (BOOL)application:(UIApplication *)application
openURL:(NSURL *)url
options:(NSDictionary<NSString *, id> *)options;

/**
* Accesses the singleton App Distribution instance.
*
Expand Down