Skip to content

Change FIAM internal symbol causing App Store warnings #10284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 28, 2022
Merged

Change FIAM internal symbol causing App Store warnings #10284

merged 1 commit into from
Sep 28, 2022

Conversation

@paulb777
Copy link
Member

@paulb777 paulb777 commented Sep 28, 2022

Fix #10276

@paulb777 paulb777 added this to the Firebase 10 - M122 milestone Sep 28, 2022
@google-oss-bot google-oss-bot added the api: inappmessaging Firebase In App Messaging label Sep 28, 2022
@paulb777 paulb777 requested a review from ncooke3 September 28, 2022 14:24
@paulb777 paulb777 enabled auto-merge (squash) September 28, 2022 14:24
@google-oss-bot
Copy link

google-oss-bot commented Sep 28, 2022

Size Report 1

Affected Products

  • FirebaseInAppMessaging

    TypeBase (8866b22)Merge (b4e2b8a)Diff
    CocoaPods?-51.5 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/iuhUmotdL5.html

@google-oss-bot
Copy link

google-oss-bot commented Sep 28, 2022

Coverage Report 1

Affected Products

  • FirebaseInAppMessaging-iOS-FirebaseInAppMessaging.framework

    Overall coverage changed from ? (8866b22) to 46.15% (b4e2b8a) by ?.

    42 individual files with coverage change

    FilenameBase (8866b22)Merge (b4e2b8a)Diff
    FIRIAMActionURLFollower.m?52.78%?
    FIRIAMActivityLogger.m?60.96%?
    FIRIAMAnalyticsEventLoggerImpl.m?60.71%?
    FIRIAMBannerViewController.m?0.00%?
    FIRIAMBannerViewUIWindow.m?0.00%?
    FIRIAMBaseRenderingViewController.m?0.00%?
    FIRIAMBookKeeper.m?88.41%?
    FIRIAMCardViewController.m?0.00%?
    FIRIAMClearcutHttpRequestSender.m?0.00%?
    FIRIAMClearcutLogger.m?62.50%?
    FIRIAMClearcutLogStorage.m?62.50%?
    FIRIAMClearcutUploader.m?90.34%?
    FIRIAMClientInfoFetcher.m?61.98%?
    FIRIAMDefaultDisplayImpl.m?1.78%?
    FIRIAMDisplayCheckOnAnalyticEventsFlow.m?0.00%?
    FIRIAMDisplayCheckOnAppForegroundFlow.m?0.00%?
    FIRIAMDisplayCheckOnFetchDoneNotificationFlow.m?0.00%?
    FIRIAMDisplayCheckTriggerFlow.m?0.00%?
    FIRIAMDisplayExecutor.m?65.99%?
    FIRIAMDisplayTriggerDefinition.m?68.42%?
    FIRIAMElapsedTimeTracker.m?92.31%?
    FIRIAMFetchFlow.m?80.35%?
    FIRIAMFetchOnAppForegroundFlow.m?0.00%?
    FIRIAMFetchResponseParser.m?86.11%?
    FIRIAMImageOnlyViewController.m?0.00%?
    FIRIAMMessageClientCache.m?78.11%?
    FIRIAMMessageContentDataWithImageURL.m?80.88%?
    FIRIAMMessageDefinition.m?100.00%?
    FIRIAMModalViewController.m?0.00%?
    FIRIAMMsgFetcherUsingRestful.m?71.01%?
    FIRIAMRenderingEffectSetting.m?100.00%?
    FIRIAMRenderingWindowHelper.m?0.00%?
    FIRIAMRuntimeManager.m?0.00%?
    FIRIAMSDKModeManager.m?93.22%?
    FIRIAMSDKSettings.m?0.00%?
    FIRIAMServerMsgFetchStorage.m?0.00%?
    FIRIAMTimeFetcher.m?0.00%?
    FIRInAppMessaging+Bootstrap.m?0.00%?
    FIRInAppMessaging.m?3.37%?
    FIRInAppMessagingRenderingDataClasses.m?89.29%?
    NSString+FIRInterlaceStrings.m?100.00%?
    UIColor+FIRIAMHexString.m?100.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/uD7Lx5BP8l.html

@paulb777 paulb777 changed the title pb-fiam-app-store Change FIAM internal symbol causing App Store warnings Sep 28, 2022
@paulb777 paulb777 merged commit 55440b6 into master Sep 28, 2022
@paulb777 paulb777 deleted the pb-fiam-app-store branch September 28, 2022 14:35
@ncooke3
Copy link
Member

ncooke3 commented Sep 28, 2022 •
edited
Loading

CocoaPods-10.0.0 tags have been updated to include this commit.

@ncooke3
Copy link
Member

ncooke3 commented Sep 28, 2022 •
edited
Loading

New zip being built at https://github.com/firebase/firebase-ios-sdk/actions/runs/3144589094

@firebase firebase locked and limited conversation to collaborators Oct 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ncooke3 ncooke3 ncooke3 approved these changes

Assignees

No one assigned

Labels

api: inappmessaging Firebase In App Messaging

Projects

None yet

Milestone

Firebase 10 - M122

Development

Successfully merging this pull request may close these issues.

"App Store Connect Operation Error" warning for an app depends on FIAM

3 participants

@paulb777 @google-oss-bot @ncooke3