Skip to content

FDL: Mark FIRDynamicLink's init as NS_UNAVAILABLE #10236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 20, 2022
Merged

FDL: Mark FIRDynamicLink's init as NS_UNAVAILABLE #10236

merged 3 commits into from
Sep 20, 2022

Conversation

@andrewheard
Copy link
Contributor

@andrewheard andrewheard commented Sep 20, 2022

DynamicLink's initializer was not intended to be publicly available. Marking it as NS_UNAVAILABLE hides it from both ObjC and Swift callers; resolves #10000.

@andrewheard
FDL: Mark FIRDynamicLink's init as NS_UNAVAILABLE
c89f6b3 
DynamicLink's initializer was not intended to be publicly available. Marking it as NS_UNAVAILABLE hides it from both ObjC and Swift callers; resolves #10000.
@andrewheard andrewheard added this to the Firebase 10 - M122 milestone Sep 20, 2022
@andrewheard andrewheard self-assigned this Sep 20, 2022
@google-oss-bot
Copy link

google-oss-bot commented Sep 20, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • FirebaseDynamicLinks-iOS-FirebaseDynamicLinks.framework

    Overall coverage changed from 61.11% (2d89f55) to 60.89% (1be1099) by -0.22%.

    FilenameBase (2d89f55)Merge (1be1099)Diff
    FIRDynamicLink.m78.70%74.07%-4.63%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Du1K3J9C2I.html

@google-oss-bot
Copy link

google-oss-bot commented Sep 20, 2022

Size Report 1

Affected Products

  • FirebaseDynamicLinks

    TypeBase (2d89f55)Merge (1be1099)Diff
    CocoaPods568 kB-51.5 kB-620 kB (-109.1%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/MxsnEYXot7.html

paulb777
paulb777 approved these changes Sep 20, 2022
View reviewed changes
@andrewheard andrewheard merged commit 5d7d52c into master Sep 20, 2022
@andrewheard andrewheard deleted the ah-fdl-init branch September 20, 2022 22:20
@firebase firebase locked and limited conversation to collaborators Oct 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@paulb777 paulb777 paulb777 approved these changes

@ncooke3 ncooke3 Awaiting requested review from ncooke3

Assignees

@andrewheard andrewheard

Labels

api: dynamiclinks public-api-change Swift API

Projects

None yet

Milestone

Firebase 10 - M122

Development

Successfully merging this pull request may close these issues.

DynamicLink initializer shouldn't be available from Swift

3 participants

@andrewheard @google-oss-bot @paulb777