Skip to content

FIAM: Remove extraneous foo constant in Swift preview helpers #10222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 15, 2022
Merged

FIAM: Remove extraneous foo constant in Swift preview helpers #10222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
020bf52
FIAM: Remove extraneous `foo` in PreviewHelpers
andrewheard Sep 15, 2022
6a5667a
Added changelog entry
andrewheard Sep 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions FirebaseInAppMessaging/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# 10.0.0
- [removed] Removed `foo` constant from Swift `InAppMessagingPreviewHelpers` API (#10222).

# 9.2.0
- [changed] Replaced unarchiveObjectWithFile with unarchivedObjectOfClass to conform to secure coding practices, and implemented NSSecureCoding (#9816).

Expand Down
1 change: 0 additions & 1 deletion FirebaseInAppMessaging/Swift/Source/SwiftUIPreviewHelpers.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import FirebaseInAppMessaging
@available(iOSApplicationExtension, unavailable)
@available(tvOSApplicationExtension, unavailable)
public enum InAppMessagingPreviewHelpers {
public static let foo = UIColor.black
public static func cardMessage(campaignName: String = "Card message campaign",
title: String = "Title for modal message",
body: String? = "Body for modal message",
Expand Down