Remove erroneous logic in ComputeViews. #10101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See similar logic in [Android](https://cs.opensource.google/firebase-sdk/firebase-android-sdk/+/master:firebase-firestore/src/main/java/com/google/firebase/firestore/local/LocalDocumentsView.java;l=173-176?q=LocalDocumentsView.java&ss=firebase-sdk%2Ffirebase-android-sdk) and [Web](https://cs.opensource.google/firebase-sdk/firebase-js-sdk/+/master:packages/firestore/src/local/local_documents_view.ts;l=239-244?q=computeviews&ss=firebase-sdk%2Ffirebase-js-sdk). This is inserting into a map while its being iterated over. Note that SortedMap does not guarantee pointer stability. In fact, upon insertion, SortedMap may [switch](https://cs.opensource.google/firebase-sdk/firebase-ios-sdk/+/master:Firestore/core/src/immutable/sorted_map.h;l=186-197?q=sorted_map.h&ss=firebase-sdk%2Ffirebase-ios-sdk) to using a different underlying data structure (tree rather than array) which invalidates pointers. Fixes #9965.
Size Report 1Affected ProductsTest Logs |
Coverage Report 1Affected Products
Test Logs |
wu-hui
approved these changes
Aug 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See similar logic in Android and Web.
This is inserting into a map while its being iterated over. Note that SortedMap
does not guarantee pointer stability. In fact, upon insertion, SortedMap may
switch to using a different underlying data structure (tree rather than array)
which invalidates pointers.
Fixes #9965.