Firebase Performance logs too much when data collection disabled (2)

Step 1: Describe your environment

• Xcode version: 12.5
• Firebase SDK version: 8.4.0
• Installation method: CocoaPods
• Firebase Component: Performance

Step 2: Describe the problem

Reopening problem #4238:

Firebase Performance spams in log when disabled. Disabled module via isInstrumentationEnabled=false and isDataCollectionEnabled=false produces spam in log

[Firebase/Performance][I-PRF100013] Dropping event since data collection is disabled.

Suggested workaround in #4238 (set -FIRDebugEnabled) in not a fix, its silently enables Performance module.

My suggestion is change

FPRLogError(kFPRClientPerfNotConfigured, @"Dropping event since data collection is disabled.");

to

FPRLogDebug(kFPRClientPerfNotConfigured, @"Dropping event since data collection is disabled.");

Or something like that, because disabled traces is not an error at all.

[google-oss-bot]

I found a few problems with this issue:

• I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
• This issue does not seem to follow the issue template. Make sure you provide all the required information.