Implement unified emulator settings API proposal #5916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samtstern
reviewed
Jun 25, 2020
morganchen12
force-pushed
the
morganchen/emu
branch
from
92bad75 to
2797294
Compare
morganchen12
force-pushed
the
morganchen/emu
branch
from
859e9c8 to
740d830
Compare
morganchen12
changed the title
|
@morganchen12 FWIW storage is not in scope, there's no Storage emulator. |
samtstern
reviewed
Jul 30, 2020
paulb777
reviewed
Jul 30, 2020
morganchen12
force-pushed
the
morganchen/emu
branch
from
da086ac to
f8628d3
Compare
morganchen12
requested review from
paulb777,
samtstern,
schmidt-sebastian and
wilhuff
paulb777
reviewed
Oct 17, 2020
There was a problem hiding this comment.
LGTM, deferring iCore approval to @ryanwilson for API change approval
This comment has been minimized.
This comment has been minimized.
ryanwilson
reviewed
Oct 19, 2020
Functions/FirebaseFunctions/Public/FirebaseFunctions/FIRFunctions.h
Outdated
Show resolved
Hide resolved
samtstern
reviewed
Oct 19, 2020
Functions/FirebaseFunctions/Public/FirebaseFunctions/FIRFunctions.h
Outdated
Show resolved
Hide resolved
morganchen12
force-pushed
the
morganchen/emu
branch
from
e4ece34 to
583d704
Compare
schmidt-sebastian
approved these changes
Oct 28, 2020
paulb777
approved these changes
Oct 28, 2020
|
Quickstart test will be fixed by firebase/quickstart-ios#1075. @schmidt-sebastian, do you know why the integration test is failing? |
|
Could be more issues related to the GHA Xcode 12 transition. We should get the full summary from tonight's cron run. |
|
@paulb777 do you know why the quickstart test is failing with when ABTesting isn't in the list of dependencies? I wasn't able to reproduce the failure locally. |
|
@morganchen12 It's a result of this script that makes sure that all Firebase dependency pods are sourced from the repo. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API proposal in question is "Unified Emulator Connection Settings".
Googlers see b/158072394