Skip to content

Commit 740d830

Browse files
committed
Update with new API
1 parent ed4b3d5 commit 740d830

File tree

2 files changed

+17
-3
lines changed

2 files changed

+17
-3
lines changed

FirebaseCore/Sources/FIREmulatorSettings.m

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,16 +93,24 @@ - (instancetype)settingsByRemovingSettingsForService:(FIREmulatorService)service
9393
- (instancetype)settingsByAddingSettings:(FIREmulatorServiceSettings *)settings
9494
forService:(FIREmulatorService)service {
9595
NSMutableDictionary *mutableSettings = [self.settings mutableCopy];
96-
[mutableSettings addObject:settings];
96+
[mutableSettings setObject:settings forKey:service];
9797
return [[FIREmulatorSettings alloc] initWithSettings:mutableSettings];
9898
}
9999

100+
- (instancetype)settingsByAddingSettingsWithHost:(NSString *)host
101+
port:(NSInteger)port
102+
forService:(FIREmulatorService)service {
103+
FIREmulatorServiceSettings *settings =
104+
[[FIREmulatorServiceSettings alloc] initWithHost:host port:port];
105+
return [self settingsByAddingSettings:settings forService:service];
106+
}
107+
100108
- (NSDictionary *)getAllServiceSettings {
101109
return [self.settings copy];
102110
}
103111

104112
- (instancetype)copyWithZone:(NSZone *)zone {
105-
return self; // immutable, so return self
113+
return self; // immutable, so return self
106114
}
107115

108116
- (FIREmulatorServiceSettings *)settingsForService:(FIREmulatorService)service {

FirebaseCore/Sources/Public/FIREmulatorSettings.h

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,10 +77,16 @@ NS_SWIFT_NAME(EmulatorSettings)
7777
- (instancetype)settingsByRemovingSettingsForService:(FIREmulatorService)service;
7878

7979
/// Returns a new settings object that is the result of adding new settings for a given
80-
/// service.
80+
/// service. Overwrites a pre-existing settings entry for the given key, if it exists.
8181
- (instancetype)settingsByAddingSettings:(FIREmulatorServiceSettings *)settings
8282
forService:(FIREmulatorService)service
8383

84+
/// Returns a new settings object that is the result of adding new settings for a given
85+
/// service. Overwrites a pre-existing settings entry for the given key, if it exists.
86+
- (instancetype)settingsByAddingSettingsWithHost:(NSString *)host
87+
port:(NSInteger)port
88+
forService:(FIREmulatorService)service;
89+
8490
/// Returns the service-level settings object for a given emulated service, if it exists.
8591
- (FIREmulatorServiceSettings *_Nullable)settingsForService:(FIREmulatorService)service;
8692

0 commit comments

Comments
 (0)