Skip to content

Conversation

@rlazo
Copy link
Contributor

@rlazo rlazo commented Jan 31, 2025

Token measurement is broken down by modaliy, with separate counters for image, audio, etc.

rlazo added 2 commits January 30, 2025 14:31
Token measurement is broken down by modaliy, with separate counters for
image, audio, etc.
@rlazo
Copy link
Contributor Author

rlazo commented Feb 8, 2025

friendly ping

@rlazo rlazo enabled auto-merge (squash) February 8, 2025 04:17
@rlazo rlazo requested a review from paulb777 February 11, 2025 15:25
Copy link
Contributor

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple minor test nits.

Note: I'm going to add integration tests in a separate PR.

@rlazo rlazo requested a review from andrewheard February 11, 2025 20:39
@rlazo
Copy link
Contributor Author

rlazo commented Feb 11, 2025

Comments addressed. Also, added change to make fields non-nullable

cc @andrewheard

Copy link
Contributor

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green CI.

@rlazo rlazo merged commit 44fe5d0 into main Feb 11, 2025
30 of 38 checks passed
@rlazo rlazo deleted the rl.token.count.breakdown branch February 11, 2025 20:41
@firebase firebase locked and limited conversation to collaborators Mar 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants