Skip to content

Conversation

@andrewheard
Copy link
Contributor

@andrewheard andrewheard commented Sep 15, 2022

Removed an unintentional constant named "foo" from the Firebase In-App Messaging Swift API. This constant is not of use to developers (simply containing UIColor.black) and was only added accidentally. Closes #9998.

Removed an unintentional constant named "foo" from the Firebase In-App Messaging Swift API. This constant is not of use to developers (simply containing UIColor.black) and was only added accidentally.

#no-changelog
@andrewheard andrewheard added api: inappmessaging Firebase In App Messaging Swift API labels Sep 15, 2022
@andrewheard andrewheard added this to the Firebase 10 - M122 milestone Sep 15, 2022
@andrewheard andrewheard self-assigned this Sep 15, 2022
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't hurt to have a changelog just in case someone was accidentally using it.

@andrewheard
Copy link
Contributor Author

Wouldn't hurt to have a changelog just in case someone was accidentally using it.

Good idea. I could see myself using it as a joke or thinking it's an Easter egg.

@andrewheard andrewheard reopened this Sep 15, 2022
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@andrewheard andrewheard merged commit 0b0785f into master Sep 15, 2022
@andrewheard andrewheard deleted the ah-fiam-foo branch September 15, 2022 22:30
@firebase firebase locked and limited conversation to collaborators Oct 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: inappmessaging Firebase In App Messaging Swift API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecate unintentional public API foo in FIAM Swift

2 participants