Skip to content

Remove format from double helper function #6432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 6, 2024
Merged

Remove format from double helper function #6432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c88a4cc
Remove format for `double` helper functions
rlazo Nov 5, 2024
5564d5e
Merge branch 'main' into rl.double.format
rlazo Nov 5, 2024
5ab44a5
Add changelog
rlazo Nov 5, 2024
2ddbee8
Fix tests
rlazo Nov 5, 2024
a63d93d
Merge branch 'main' into rl.double.format
rlazo Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions firebase-vertexai/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
* [fixed] Improved error message when using an invalid location. (#6428)
* [fixed] Fixed issue where Firebase App Check error tokens were unintentionally missing from the requests. (#6409)
* [fixed] Clarified in the documentation that `Schema.integer` and `Schema.float` only provide hints to the model. (#6420)
* [fixed] Fixed issue were `Schema.double` set the format parameter in `Schema`. (#6432)

# 16.0.1
* [fixed] Fixed issue where authorization headers weren't correctly formatted and were ignored by the backend. (#6400)
Expand Down
2 changes: 1 addition & 1 deletion firebase-vertexai/src/main/kotlin/com/google/firebase/vertexai/type/Schema.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ internal constructor(
@JvmName("numDouble")
@JvmOverloads
public fun double(description: String? = null, nullable: Boolean = false): Schema =
Schema(description = description, nullable = nullable, type = "NUMBER", format = "double")
Schema(description = description, nullable = nullable, type = "NUMBER")

/**
* Returns a [Schema] for a single-precision floating-point number.
Expand Down
10 changes: 5 additions & 5 deletions firebase-vertexai/src/test/java/com/google/firebase/vertexai/SchemaTests.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,8 @@ internal class SchemaTests {
"coordinates": {
"type": "OBJECT",
"properties": {
"latitude": {"type": "NUMBER", "format": "double"},
"longitude": {"type": "NUMBER","format": "double"}
"latitude": {"type": "NUMBER"},
"longitude": {"type": "NUMBER"}
},
"required": ["latitude","longitude"]
},
Expand All @@ -82,7 +82,7 @@ internal class SchemaTests {
},
"required": ["latitudinal","longitudinal"]
},
"elevation": {"type": "NUMBER","format": "double"},
"elevation": {"type": "NUMBER"},
"isCapital": {"type": "BOOLEAN"},
"foundingDate": {"type": "STRING","format": "date","nullable": true}
},
Expand Down Expand Up @@ -177,8 +177,8 @@ internal class SchemaTests {
"description": "coordinates",
"nullable": true,
"properties": {
"latitude": {"type": "NUMBER", "description": "latitude", "format": "double"},
"longitude": {"type": "NUMBER", "description": "longitude", "format": "double"}
"latitude": {"type": "NUMBER", "description": "latitude"},
"longitude": {"type": "NUMBER", "description": "longitude"}
},
"required": ["latitude","longitude"]
},
Expand Down
Loading