Support AGP 3.6+ in the iid compatibility check. #1409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AGP 3.6 introduced a breaking change to lint-api making the check fail. The change switch to use reflection to support both versions of the api. Additionally the change makes the check failures more developer friendly to make sure this check does not cause failures in upcoming AGP versions. Versions tested: 3.2 through 4.1.0-alpha04 Fixes #1407
vkryachko
requested review from
andirayo and
ankitaj224
and removed request for
ankitaj224
Coverage ReportAffected SDKs
Test Logs
NotesHTML coverage reports can be produced locally with./gradlew <product>:checkCoverage. Report files are located at <product-build-dir>/reports/jacoco/.
|
Binary Size ReportAffected SDKs
Test Logs |
samtstern
approved these changes
Apr 1, 2020
ashwinraghav
reviewed
Apr 1, 2020
...hecks/src/main/java/com/google/firebase/installations/lint/IncompatibleIidVersionDetector.kt
Show resolved
Hide resolved
ashwinraghav
approved these changes
Apr 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AGP 3.6 introduced a breaking change to lint-api making the check fail.
The change switch to use reflection to support both versions of the api.
Additionally the change makes the check failures more developer friendly
to make sure this check does not cause failures in upcoming AGP
versions.
Versions tested: 3.2 through 4.1.0-alpha04
Fixes #1407