Skip to content

Conversation

@ritalwar
Copy link
Contributor

@ritalwar ritalwar commented Oct 4, 2023

Proposed commit message

  • This PR adds dimensions for node datastream of Redis Enterprise to support TSDB enablement.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Screenshots

@ritalwar ritalwar requested a review from a team as a code owner October 4, 2023 14:02
@ritalwar ritalwar mentioned this pull request Oct 4, 2023
11 tasks
@elasticmachine
Copy link

elasticmachine commented Oct 4, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-16T06:58:36.401+0000

  • Duration: 15 min 53 sec

Test stats 🧪

Test Results
Failed 0
Passed 5
Skipped 0
Total 5

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Oct 4, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 50.0% (4/8) 👎 -47.531
Lines 100.0% (0/0) 💚 17.607
Conditionals 100.0% (0/0) 💚

@ritalwar ritalwar requested a review from agithomas October 9, 2023 06:29
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ritalwar
Copy link
Contributor Author

/test

Copy link
Contributor

@harnish-crest-data harnish-crest-data left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ritalwar ritalwar merged commit 4132ad3 into elastic:main Nov 18, 2023
@elasticmachine
Copy link

Package redisenterprise - 0.8.0 containing this change is available at https://epr.elastic.co/search?package=redisenterprise

@andrewkroh andrewkroh added the Integration:redisenterprise Redis Enterprise label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:redisenterprise Redis Enterprise

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants