Skip to content

[Metrics][Docker] Add link to Docker available keys #4952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 13, 2023
+7 −2
Merged

[Metrics][Docker] Add link to Docker available keys #4952

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aea514a
Add link to keys.
constanca-m Jan 9, 2023
ed4ce49
Update changelog.yml
constanca-m Jan 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/docker/changelog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
# newer versions go on top
- version: "2.4.1"
Copy link
Contributor

@MichaelKatsoulis MichaelKatsoulis Jan 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it is an enhancement it is better to go to next minor versions 2.5.0

Copy link
Contributor

@gsantoro gsantoro Jan 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's just a link to docs in the UI. I am not sure it is worth adding a major version

Copy link
Contributor Author

@constanca-m constanca-m Jan 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left it as 2.4.1 because it is something minimal, like @gsantoro said. Should I change it anyway? @MichaelKatsoulis

Copy link
Contributor

@MichaelKatsoulis MichaelKatsoulis Jan 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok leave it as it is.

changes:
- description: Add link to docker available keys
type: enhancement
link: http://github.com/elastic/integrations/pull/4952
- version: "2.4.0"
changes:
- description: Improve package description and titles
Expand Down
2 changes: 1 addition & 1 deletion packages/docker/data_stream/container_logs/manifest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ streams:
default: all
- name: condition
title: Condition
description: Condition to filter when to apply this datastream
description: Condition to filter when to apply this datastream. Refer to [Docker provider](https://www.elastic.co/guide/en/fleet/current/docker-provider.html) to find the available keys.
type: text
multi: false
required: false
Expand Down
2 changes: 1 addition & 1 deletion packages/docker/manifest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: docker
title: Docker
version: 2.4.0
version: 2.4.1
Copy link
Contributor

@MichaelKatsoulis MichaelKatsoulis Jan 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version: 2.4.1
version: 2.5.0

release: ga
description: Collect metrics and logs from Docker instances with Elastic Agent.
type: integration
Expand Down