-
Notifications
You must be signed in to change notification settings - Fork 510
[Osquery] OSQuery DFIR Saved Queries #3659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...manager/kibana/osquery_saved_query/osquery_manager-157d5550-fd27-11ec-8645-83a23bc513b5.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one comment, besides that - LGTM from Asset management :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just had one small suggested change to update the id.
Also, a question: should we add ECS mappings for any fields returned in the results? I tried testing the query to see what the results look like, but I wasn't able to run it successfully - I suspect that's because in its current form the query has some extra formatting for the json version of the saved object.
...manager/kibana/osquery_saved_query/osquery_manager-157d5550-fd27-11ec-8645-83a23bc513b5.json
Outdated
Show resolved
Hide resolved
|
@melissaburpo did it returned any error? Because it will return null if no exceptions exist |
|
The issue was that I tried to copy/paste the query directly from the PR to try running it, so it had some syntax issues (like the Thanks for sharing the screenshot though, that helps! Looking at the results, I don't think there are any ECS mappings needed for the |
|
Here are a few screenshots on the queries returning the desired results: Let me know if I can help with anything around these ;) |
...manager/kibana/osquery_saved_query/osquery_manager-0f61edf0-17e1-11ed-89c6-331eb0db6d01.json
Outdated
Show resolved
Hide resolved
...manager/kibana/osquery_saved_query/osquery_manager-a08d7320-1823-11ed-89c6-331eb0db6d01.json
Outdated
Show resolved
Hide resolved
🌐 Coverage report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@w0rk3r I think you can merge it. Let's then test the integration on staging before going on production :) |
|
https://beats-ci.elastic.co/blue/organizations/jenkins/Ingest-manager%2Fintegrations/detail/main/1201/pipeline/ this is a job triggered from this PR. Let's see what happens next 🤞 |










What does this PR do?
Adds DFIR-related saved queries to the OSQuery manager integration