Skip to content

Conversation

@legoguy1000
Copy link
Contributor

What does this PR do?

Fixes the parsing for AWS ELB URLs with spaces.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@legoguy1000 legoguy1000 marked this pull request as ready for review June 12, 2022 02:13
@legoguy1000 legoguy1000 requested a review from a team as a code owner June 12, 2022 02:13
@elasticmachine
Copy link

elasticmachine commented Jun 12, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-13T04:48:17.876+0000

  • Duration: 31 min 19 sec

Test stats 🧪

Test Results
Failed 0
Passed 328
Skipped 0
Total 328

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@paolafrancesca
Copy link

/test

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (11/11) 💚
Files 91.667% (11/12) 👎 -4.787
Classes 91.667% (11/12) 👎 -4.787
Methods 82.439% (169/205) 👎 -6.853
Lines 92.673% (2087/2252) 👍 1.87
Conditionals 100.0% (0/0) 💚

@legoguy1000
Copy link
Contributor Author

@aspacca Can we merge?

@paolafrancesca paolafrancesca merged commit 79c4a66 into elastic:main Jun 15, 2022
@legoguy1000 legoguy1000 deleted the 3491-aws-elb-fix branch June 15, 2022 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[aws] elb access logs fails to parse data

3 participants