Skip to content

Conversation

@andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Jan 28, 2022

What does this PR do?

Migrate data from Agent 7.x to ECS 8.0 format.

Agent 7.x produces process.ppid, but in order to comply with ECS 8.0
we want all data to use process.parent.pid.

The process data stream lacked any tests so I added a system test to
verify the pipeline works and validate the fields.yml. I found some
undocumented fields.

Relates #2363 #2512

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

References

@andrewkroh andrewkroh added Team:Integrations Label for the Integrations team Integration:system System labels Jan 28, 2022
@elasticmachine
Copy link

Pinging @elastic/integrations (Team:Integrations)

@andrewkroh andrewkroh mentioned this pull request Jan 28, 2022
@elasticmachine
Copy link

elasticmachine commented Jan 28, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-03-17T09:19:10.086+0000

  • Duration: 25 min 3 sec

Test stats 🧪

Test Results
Failed 0
Passed 270
Skipped 0
Total 270

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@andrewkroh
Copy link
Member Author

/test

@jsoriano jsoriano added the Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane] label Jan 28, 2022
@elasticmachine
Copy link

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

Migrate data from Agent 7.x to ECS 8.0 format.

Agent 7.x produces process.ppid, but in order to comply with ECS 8.0
we want all data to use process.parent.pid.

The process data stream lacked any tests so I added a system test to
verify the pipeline works and validate the fields.yml. I found some
undocumented fields.

Relates #2363 #2512
@andrewkroh andrewkroh requested a review from a team as a code owner March 14, 2022 17:44
Copy link
Contributor

@fearful-symmetry fearful-symmetry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, is this something we also want to change on the agent side?

Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
@andrewkroh
Copy link
Member Author

andrewkroh commented Mar 16, 2022

Looks fine to me, is this something we also want to change on the agent side?

It was changed in 8.0 in Beats (https://github.com/elastic/beats/blob/v8.0.0/metricbeat/module/system/process/process.go#L117-L118). So this ensure that data coming from 7.x Agent's will match.

@efd6
Copy link
Contributor

efd6 commented Mar 16, 2022

/test

@andrewkroh andrewkroh merged commit 09b651d into elastic:main Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:system System Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane] Team:Integrations Label for the Integrations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants