Skip to content

Conversation

@mykola-elastic
Copy link
Contributor

@mykola-elastic mykola-elastic commented Aug 19, 2025

This PR adds NTP data_stream to the system package which corresponds to the beats PR elastic/beats#44884.
It also bumps up the version requirement to ^9.2.0

Proposed commit message

See title.

Checklist

  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

Discover

Screenshot 2025-08-19 at 15 36 09

Configuration

Screenshot 2025-08-19 at 15 59 32

@mykola-elastic mykola-elastic self-assigned this Aug 19, 2025
@mykola-elastic mykola-elastic added Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] enhancement New feature or request Integration:system System labels Aug 19, 2025
@mykola-elastic mykola-elastic changed the title [system] [ntp] add ntp data_stream [DRAFt] [system] [ntp] add ntp data_stream Aug 19, 2025
@mykola-elastic mykola-elastic changed the title [DRAFt] [system] [ntp] add ntp data_stream [DRAFT] [system] [ntp] add ntp data_stream Aug 19, 2025
@mykola-elastic mykola-elastic changed the title [DRAFT] [system] [ntp] add ntp data_stream [system] [ntp] add ntp data_stream Aug 19, 2025
@mykola-elastic mykola-elastic marked this pull request as ready for review August 19, 2025 12:50
@mykola-elastic mykola-elastic requested review from a team as code owners August 19, 2025 12:50
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Aug 19, 2025

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

Copy link
Contributor

@tommyers-elastic tommyers-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to bump the kibana version to 9.2.0 here. (and we should probably wait to merge this until 9.2.0 is released).

do we want to include the clock offset on any existing dashboards?

@mykola-elastic
Copy link
Contributor Author

@tommyers-elastic what do you think about this? https://github.com/elastic/integrations/pull/14982/files#diff-89c55c1cf978566ceac8d2ee844e13faaf151d509741c574e6056ac11a5d700cR1-R3
Or should we spin up our own NTP server in docker for testing purposes?

@andrewkroh andrewkroh added the documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. label Aug 21, 2025
@ishleenk17
Copy link
Member

ishleenk17 commented Aug 22, 2025

we need to bump the kibana version to 9.2.0 here. (and we should probably wait to merge this until 9.2.0 is released).

@tommyers-elastic Do we have this metricset in any of the 8.x branch as well ?
Else we should drop the 8.18 version as well.

And yes, I would like to wait for 9.2 to be released before we merge this. Let all the other changes until 9.2 go into current stack version.

@elastic-sonarqube
Copy link

@mykola-elastic mykola-elastic changed the title [Don't merge] [system] [ntp] add ntp data_stream [system] [ntp] add ntp data_stream Oct 24, 2025
@mykola-elastic
Copy link
Contributor Author

mykola-elastic commented Oct 27, 2025

@daniela-elastic @tommyers-elastic @ishleenk17 added NTP panel to "Host overview" dashboard. Ready for review now

Screenshot 2025-10-27 at 09 38 59

@mykola-elastic
Copy link
Contributor Author

Removed that squeezed-in table from the top, and having the line graph in the bottom instead:
Screenshot 2025-10-27 at 11 07 13

@andrewkroh andrewkroh added the dashboard Relates to a Kibana dashboard bug, enhancement, or modification. label Oct 27, 2025
@mykola-elastic mykola-elastic removed the dashboard Relates to a Kibana dashboard bug, enhancement, or modification. label Oct 27, 2025
@mykola-elastic
Copy link
Contributor Author

removed dashboard changes and made the NTP datastream disabled by default

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @mykola-elastic

@mykola-elastic mykola-elastic merged commit 7563bd3 into elastic:main Oct 28, 2025
8 checks passed
@elastic-vault-github-plugin-prod

Package system - 2.7.0 containing this change is available at https://epr.elastic.co/package/system/2.7.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request Integration:system System Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants