Skip to content

Conversation

@fearful-symmetry
Copy link
Contributor

@fearful-symmetry fearful-symmetry commented Aug 2, 2021

The system integration was technically ga'ed with 1.0.0, but I never changed the actual release tag to GA. I don't think we need to bump the version, as this was technically part of 1.0.0

What does this PR do?

This bumps the version flag in 1.0.0

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have added an entry to my package's changelog.yml file.

@fearful-symmetry fearful-symmetry added bug Something isn't working, use only for issues Team:Integrations Label for the Integrations team labels Aug 2, 2021
@fearful-symmetry fearful-symmetry requested a review from a team August 2, 2021 20:05
@fearful-symmetry fearful-symmetry self-assigned this Aug 2, 2021
@elasticmachine
Copy link

Pinging @elastic/integrations (Team:Integrations)

@elasticmachine
Copy link

elasticmachine commented Aug 2, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-08-02T20:29:23.579+0000

  • Duration: 13 min 13 sec

  • Commit: 01686dd

Test stats 🧪

Test Results
Failed 0
Passed 266
Skipped 0
Total 266

Trends 🧪

Image of Build Times

Image of Tests

Copy link
Contributor

@EricDavisX EricDavisX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; should we not add the version bump in?

@fearful-symmetry
Copy link
Contributor Author

@EricDavisX Yah, that's what I wasn't sure about. technically the version was "bumped" with 1.0.0, but this is also a docs change, so we might want to do it anyway?

@EricDavisX
Copy link
Contributor

thanks - seems a good way to go. points for the changelog entry, too! :)

@fearful-symmetry fearful-symmetry merged commit d71747f into elastic:master Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues Team:Integrations Label for the Integrations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants