Fix: prevent duplication of "invalid index name" string in the final exception error message #130027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dropping asterisk in `IdentifierBuilder#resolveAndValidateIndex()`
|
Okay, so I found that the ordering of the invalid chars differed between |
elasticsearchmachine
added
the
needs:triage
pawankartik-elastic
added
>bug
Team:Analytics
elasticsearchmachine
removed
the
needs:triage
|
Hi @pawankartik-elastic, I've created a changelog YAML for you. |
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 3, 2025
…exception error message (elastic#130027) * Use `throwInvalidIndexNameException()` to throw invalid ex after dropping asterisk in `IdentifierBuilder#resolveAndValidateIndex()` * Assert the message in test * Refactor * drop invalid chars from assertion string due to randomisation issue * Re-assert invalid chars * Update docs/changelog/130027.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to prevent the duplication of "invalid index name" in the final exception error message:
Invalid index name [index_name_here], invalid index name ... must not contain the following characters ..... I've already made the changes for 8.19 in the backport PR here: #130021.