-
Notifications
You must be signed in to change notification settings - Fork 25.6k
SearchServiceTests.testParseSourceValidation failure #117963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SearchServiceTests.testParseSourceValidation failure #117963
Conversation
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
|
Hi @drempapis, I've created a changelog YAML for you. |
…e' of github.com:drempapis/elasticsearch into fix/SearchServiceTests.testParseSourceValidation_failure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
| ); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that you can delete the assertCreateContextValidation method too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
|
Don't forget to close #115936 once this gets merged ;) |
This test has been failing due to #113081, which deleted the incoming search validation on the data node for bwc.
In this work, #105150, validation has been moved to the coordinate nodes. The following is a matrix of the validation Exception messages of the
SearchServicemoving toSearchRequest, including a test creation checking.