Skip to content

Conversation

@srishti-saraswat
Copy link

Increase timeout to fix flaky connect distributed test.

@srishti-saraswat srishti-saraswat marked this pull request as ready for review May 12, 2025 04:09
Copilot AI review requested due to automatic review settings May 12, 2025 04:09
@srishti-saraswat srishti-saraswat requested review from a team as code owners May 12, 2025 04:09
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR increases timeout values in Connect tests to address flaky distributed test behavior.

  • Increased timeout for loggers waiting and connector state verification in connect_distributed_test.py
  • Raised the startup timeout parameter in ConnectServiceBase to allow more time for service startup

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
tests/kafkatest/tests/connect/connect_distributed_test.py Increased wait_until timeouts in logger and connector state checks
tests/kafkatest/services/connect.py Updated ConnectServiceBase constructor to use a longer startup timeout

@srishti-saraswat
Copy link
Author

Test failure is unrelated.

@sharanrudresh sharanrudresh removed the request for review from omkreddy May 16, 2025 09:20
@omkreddy omkreddy merged commit 862cfa3 into master May 16, 2025
1 of 2 checks passed
@omkreddy omkreddy deleted the fix-connect-test branch May 16, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants