fix an issue where starting app in bg causes focus to move away from … #901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonskiser
approved these changes
Nov 4, 2025
|
|
||
| "$macos_bin/$DESKTOP_BINARY_NAME" --no-dashboard > /dev/null 2>&1 & | ||
| open -g -a "$MACOS_APP_DIR/$app_name" --args --no-dashboard | ||
| sleep 3 |
There was a problem hiding this comment.
Why do we need to sleep?
There was a problem hiding this comment.
rn, we immediately print that installation was successful and finish up the installation. If the user tries to start kiro-cli right after that, it may lead to a situation where the command doesn't immediately succeed, because we don't have the symlinks in place
There was a problem hiding this comment.
Rather than fixed sleep, shall we check for completion of expected work? We can add timeouts and when we are unable to verify completion, then we can have call for action to users to open the desktop App (worst case scenario)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…terminal
Issue #, if available:
Description of changes:
fix an issue where starting app in bg causes focus to move away from …
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.