-
Notifications
You must be signed in to change notification settings - Fork 14.8k
KAFKA-18904: Add Admin#listConfigResources [2/N] #19743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: PoAn Yang <payang@apache.org>
Signed-off-by: PoAn Yang <payang@apache.org>
|
Flaky cases |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. A few comments from an initial review.
clients/src/main/java/org/apache/kafka/common/requests/ListConfigResourcesResponse.java
Outdated
Show resolved
Hide resolved
clients/src/main/java/org/apache/kafka/common/requests/ListConfigResourcesRequest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: PoAn Yang <payang@apache.org>
Signed-off-by: PoAn Yang <payang@apache.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates. Just a few additional comments.
clients/src/main/java/org/apache/kafka/clients/admin/Admin.java
Outdated
Show resolved
Hide resolved
| * @return The ListClientMetricsResourcesResult. | ||
| * @deprecated Since 4.1. Use {@link #listConfigResources()} instead. | ||
| */ | ||
| @Deprecated(since = "4.1") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
, forRemoval = true.
clients/src/main/java/org/apache/kafka/common/requests/ListConfigResourcesRequest.java
Outdated
Show resolved
Hide resolved
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala
Show resolved
Hide resolved
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala
Show resolved
Hide resolved
Signed-off-by: PoAn Yang <payang@apache.org>
Signed-off-by: PoAn Yang <payang@apache.org>
|
Looks like a failed test: FAILED ❌ KafkaApisTest > testListConfigResourcesV0() |
Signed-off-by: PoAn Yang <payang@apache.org>
Sorry for that. The v0 doesn't support resource types field. If the version is 0, we have to build a new empty |
Signed-off-by: PoAn Yang <payang@apache.org>
|
Test failed of |
|
The |
listConfigResources(Set<ConfigResource.Type> configResourceTypes, ListConfigResourcesOptions options)andlistConfigResources()toAdmininterface.CLIENT_METRICSandrequest version is 0, return
UnsupportedVersionException.listClientMetricsResources(ListClientMetricsResourcesOptions options)and
listClientMetricsResources().ListClientMetricsResourcesResultandClientMetricsResourceListing.ClientMetricsCommandto uselistConfigResources.PlaintextAdminIntegrationTest.java.KafkaAdminClientTest.java.Reviewers: Andrew Schofield aschofield@confluent.io