KAFKA-19226: Added test_console_share_consumer.py #19708
Conversation
AndrewJSchofield
added
KIP-932
| .describedAs("consumer_prop") | ||
| .ofType(String.class); | ||
| OptionSpec<String> consumerConfigOpt = parser.accepts("consumer-config", "Consumer config properties file. Note that " + consumerPropertyOpt + " takes precedence over this config.") | ||
| OptionSpec<String> consumerConfigOpt = parser.accepts("consumer.config", "Consumer config properties file. Note that " + consumerPropertyOpt + " takes precedence over this config.") |
There was a problem hiding this comment.
Please revert this. This does not match the KIP. (I have a draft KIP to align command options for the various tools.)
| """ | ||
| The console consumer is a tool that reads data from Kafka and outputs it to standard output. | ||
| """ | ||
|
|
There was a problem hiding this comment.
I am surprised this file has any changes at all.
|
|
||
| from kafkatest.directory_layout.kafka_path import KafkaPathResolverMixin | ||
| from kafkatest.services.monitor.jmx import JmxMixin, JmxTool | ||
| from kafkatest.version import DEV_BRANCH, LATEST_3_7, get_version, LATEST_4_0 |
There was a problem hiding this comment.
I would have said this should be DEV_BRANCH, get_version, LATEST_4_1. Specifically not 3.7.
There was a problem hiding this comment.
Thanks for the review. Actually, none of the imports LATEST_3_7, get_version, LATEST_4_0 are being used. I will remove them all, since the file only uses DEV_BRANCH. The version of DEV_BRANCH is 4.1.0, so that should be fine
There was a problem hiding this comment.
Until DEV_BRANCH moves forwards to 4.2. I think perhaps you'd put DEV_BRANCH, LATEST_4_1 for future-proofing.
| "export KAFKA_OPTS=%(kafka_opts)s; " \ | ||
| "%(console_share_consumer)s " \ | ||
| "--topic %(topic)s " \ | ||
| "--consumer.config %(config_file)s " % args |
| cmd += " --bootstrap-server %(broker_list)s" % args | ||
|
|
||
| if self.share_consumer_timeout_ms is not None: | ||
| # version 0.8.X and below do not support --timeout-ms option |
There was a problem hiding this comment.
This line of comment is not relevant.
| if self.print_partition: | ||
| cmd += " --property print.partition=true" | ||
|
|
||
| # LoggingMessageFormatter was introduced after 0.9 |
| for line in share_consumer_output: | ||
| msg = line.strip() | ||
| if msg == "shutdown_complete": | ||
| # Note that we can only rely on shutdown_complete message if running 0.10.0 or greater |
|
@chirag-wadhwa5 Please merge latest changes. |
| wait_until(lambda: self.has_log_message(node, message), | ||
| timeout_sec=60, | ||
| err_msg="Offset not reset for partition %s-%d" % (topic, partition)) | ||
|
|
There was a problem hiding this comment.
nit: Please revert this changed line too. This PR should not make any changes to unrelated files.
There was a problem hiding this comment.
Thanks for the review. I was pretty sure I added the end line back. It was probably a mistake, sorry about that.
2 participants
This PR includes the system test file test_console_share_consumer.py
which tests the functioning of ConsoleShareConsumer
Reviewers: Andrew Schofield aschofield@confluent.io