KAFKA-19042: [7/N] Move PlaintextConsumerPollTest to client-integration-tests module #19582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
...egration-tests/src/test/java/org/apache/kafka/clients/consumer/ConsumerAssignmentPoller.java
Outdated
Show resolved
Hide resolved
...egration-tests/src/test/java/org/apache/kafka/clients/consumer/ConsumerAssignmentPoller.java
Outdated
Show resolved
Hide resolved
...egration-tests/src/test/java/org/apache/kafka/clients/consumer/ConsumerAssignmentPoller.java
Outdated
Show resolved
Hide resolved
frankvicky
reviewed
Apr 29, 2025
...egration-tests/src/test/java/org/apache/kafka/clients/consumer/ConsumerAssignmentPoller.java
Outdated
Show resolved
Hide resolved
...egration-tests/src/test/java/org/apache/kafka/clients/consumer/ConsumerAssignmentPoller.java
Outdated
Show resolved
Hide resolved
...egration-tests/src/test/java/org/apache/kafka/clients/consumer/ConsumerAssignmentPoller.java
Outdated
Show resolved
Hide resolved
...egration-tests/src/test/java/org/apache/kafka/clients/consumer/ConsumerAssignmentPoller.java
Outdated
Show resolved
Hide resolved
...egration-tests/src/test/java/org/apache/kafka/clients/consumer/ConsumerAssignmentPoller.java
Outdated
Show resolved
Hide resolved
| ) | ||
| public class PlaintextConsumerPollTest { | ||
|
|
||
| public static final int BROKER_COUNT = 3; |
There was a problem hiding this comment.
Use short to eliminate the casting.
There was a problem hiding this comment.
The @ClusterTestDefaults brokers type is int, thus we should set BROKER_COUNT as int
chia7712
reviewed
May 2, 2025
...egration-tests/src/test/java/org/apache/kafka/clients/consumer/ConsumerAssignmentPoller.java
Outdated
Show resolved
Hide resolved
...egration-tests/src/test/java/org/apache/kafka/clients/consumer/ConsumerAssignmentPoller.java
Outdated
Show resolved
Hide resolved
...egration-tests/src/test/java/org/apache/kafka/clients/consumer/ConsumerAssignmentPoller.java
Outdated
Show resolved
Hide resolved
...gration-tests/src/test/java/org/apache/kafka/clients/consumer/PlaintextConsumerPollTest.java
Outdated
Show resolved
Hide resolved
chia7712
reviewed
May 5, 2025
...egration-tests/src/test/java/org/apache/kafka/clients/consumer/ConsumerAssignmentPoller.java
Outdated
Show resolved
Hide resolved
chia7712
reviewed
May 5, 2025
...egration-tests/src/test/java/org/apache/kafka/clients/consumer/ConsumerAssignmentPoller.java
Outdated
Show resolved
Hide resolved
...gration-tests/src/test/java/org/apache/kafka/clients/consumer/PlaintextConsumerPollTest.java
Outdated
Show resolved
Hide resolved
...gration-tests/src/test/java/org/apache/kafka/clients/consumer/PlaintextConsumerPollTest.java
Outdated
Show resolved
Hide resolved
|
@m1a2st could you please fix the conflicts? |
# Conflicts: # core/src/test/scala/integration/kafka/api/PlaintextConsumerPollTest.scala
chia7712
reviewed
May 19, 2025
|
|
||
| // continuous poll should eventually fail because there is no offset reset strategy set | ||
| // (fail only when resetting positions after coordinator is known) | ||
| TestUtils.waitForCondition(() -> { |
There was a problem hiding this comment.
TestUtils.waitForCondition(() -> {
try {
consumer.poll(Duration.ZERO);
return false;
} catch (NoOffsetForPartitionException e) {
return true;
}
}, "Continuous poll not fail");WDYT?
There was a problem hiding this comment.
It's good idea, addressed it.
...gration-tests/src/test/java/org/apache/kafka/clients/consumer/PlaintextConsumerPollTest.java
Show resolved
Hide resolved
# Conflicts: # core/src/test/scala/integration/kafka/api/PlaintextConsumerPollTest.scala
chia7712
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Java to rewrite PlaintextConsumerPollTest by new test infra and move
it to client-integration-tests module.
Reviewers: PoAn Yang payang@apache.org, TengYao Chi
kitingiao@gmail.com, Chia-Ping Tsai chia7712@gmail.com